Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2532313003:
Show an info icon with a tooltip for PSL-matches in the account chooser on Views. (Closed)
DescriptionShow an info icon with a tooltip for PSL-matches in the account chooser on Views.
The actual icon is taken from LOCATION_BAR_HTTP.
BUG=666340
Committed: https://crrev.com/b35160455293212a373c044cf84494ca4ea75d58
Cr-Commit-Position: refs/heads/master@{#435613}
Patch Set 1 #Patch Set 2 : fix include #
Total comments: 7
Patch Set 3 : comments #Patch Set 4 : delete the icon #
Messages
Total messages: 27 (19 generated)
The CQ bit was checked by vasilii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
vasilii@chromium.org changed reviewers: + estade@chromium.org, vabr@chromium.org
Hi guys, please review. The screenshot is attached to the bug.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by vasilii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Show an info icon with a tooltip for PSL-matches in the account chooser on Views. The actual icon is taken from LOCATION_BAR_HTTP. BUG=666340 ========== to ========== Show an info icon with a tooltip for PSL-matches in the account chooser on Views. The actual icon is taken from LOCATION_BAR_HTTP. BUG=666340 ==========
LGTM, thanks! Vaclav
https://codereview.chromium.org/2532313003/diff/20001/chrome/browser/ui/views... File chrome/browser/ui/views/passwords/credentials_item_view.cc (right): https://codereview.chromium.org/2532313003/diff/20001/chrome/browser/ui/views... chrome/browser/ui/views/passwords/credentials_item_view.cc:191: icon_rect.Offset(-kInfoIconSize, (child_area.height() - kInfoIconSize) / 2); I had a hard time reading this (the screenshot helped). Consider: gfx::Rect(child_area.right() - kInfoIconSize, (child_area.height() - kInfoIconSize) / 2, kInfoIconSize, kInfoIconSize); or info_button_->SizeToPreferredSize(); info_button_->SetPosition(gfx::Point(child_area.right() - info_button_->width(), (child_area.height() - info_button_->height()) / 2)); https://codereview.chromium.org/2532313003/diff/20001/chrome/browser/ui/views... chrome/browser/ui/views/passwords/credentials_item_view.cc:205: DCHECK(sender == info_button_); DCHECK_EQ but why is this a button if you don't care if it's clicked? Why not just an imageview with a tooltip? In fact it seems like you should be reusing TooltipIcon as it's a very similar ui (your designer may or may not be aware of that part of the autofill card unmasking prompt). https://codereview.chromium.org/2532313003/diff/20001/ui/gfx/vector_icons/inf... File ui/gfx/vector_icons/information.icon (right): https://codereview.chromium.org/2532313003/diff/20001/ui/gfx/vector_icons/inf... ui/gfx/vector_icons/information.icon:1: // Copyright 2016 The Chromium Authors. All rights reserved. I think you just want to use info_outline.icon
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by vasilii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2532313003/diff/20001/chrome/browser/ui/views... File chrome/browser/ui/views/passwords/credentials_item_view.cc (right): https://codereview.chromium.org/2532313003/diff/20001/chrome/browser/ui/views... chrome/browser/ui/views/passwords/credentials_item_view.cc:191: icon_rect.Offset(-kInfoIconSize, (child_area.height() - kInfoIconSize) / 2); On 2016/11/29 15:06:50, Evan Stade wrote: > I had a hard time reading this (the screenshot helped). Consider: > > gfx::Rect(child_area.right() - kInfoIconSize, (child_area.height() - > kInfoIconSize) / 2, kInfoIconSize, kInfoIconSize); > > or > > info_button_->SizeToPreferredSize(); > info_button_->SetPosition(gfx::Point(child_area.right() - info_button_->width(), > (child_area.height() - info_button_->height()) / 2)); Done. https://codereview.chromium.org/2532313003/diff/20001/chrome/browser/ui/views... chrome/browser/ui/views/passwords/credentials_item_view.cc:205: DCHECK(sender == info_button_); On 2016/11/29 15:06:50, Evan Stade wrote: > DCHECK_EQ > > but why is this a button if you don't care if it's clicked? Why not just an > imageview with a tooltip? In fact it seems like you should be reusing > TooltipIcon as it's a very similar ui (your designer may or may not be aware of > that part of the autofill card unmasking prompt). Done. I'll ask the designer. I feel that many rows with (?) look worse than with (i). https://codereview.chromium.org/2532313003/diff/20001/ui/gfx/vector_icons/inf... File ui/gfx/vector_icons/information.icon (right): https://codereview.chromium.org/2532313003/diff/20001/ui/gfx/vector_icons/inf... ui/gfx/vector_icons/information.icon:1: // Copyright 2016 The Chromium Authors. All rights reserved. On 2016/11/29 15:06:50, Evan Stade wrote: > I think you just want to use info_outline.icon I changed but it doesn't look as nice (see the second screenshot). I think the icon was sized from 32 to 16. Should I leave it?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2532313003/diff/20001/chrome/browser/ui/views... File chrome/browser/ui/views/passwords/credentials_item_view.cc (right): https://codereview.chromium.org/2532313003/diff/20001/chrome/browser/ui/views... chrome/browser/ui/views/passwords/credentials_item_view.cc:205: DCHECK(sender == info_button_); On 2016/11/29 17:23:03, vasilii wrote: > On 2016/11/29 15:06:50, Evan Stade wrote: > > DCHECK_EQ > > > > but why is this a button if you don't care if it's clicked? Why not just an > > imageview with a tooltip? In fact it seems like you should be reusing > > TooltipIcon as it's a very similar ui (your designer may or may not be aware > of > > that part of the autofill card unmasking prompt). > > Done. I'll ask the designer. I feel that many rows with (?) look worse than with > (i). Hwi said that the autofill dialog should switch to (i) and dark tooltip due to Project Harmony :-P
The CQ bit was checked by vasilii@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from vabr@chromium.org Link to the patchset: https://codereview.chromium.org/2532313003/#ps60001 (title: "delete the icon")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1480598655604670,
"parent_rev": "38a39d12640911ee5f663058512ba7b90c339ed5", "commit_rev":
"5885e7c8c214a9e2bfc13bc6c1f5835795a56443"}
Message was sent while issue was closed.
Description was changed from ========== Show an info icon with a tooltip for PSL-matches in the account chooser on Views. The actual icon is taken from LOCATION_BAR_HTTP. BUG=666340 ========== to ========== Show an info icon with a tooltip for PSL-matches in the account chooser on Views. The actual icon is taken from LOCATION_BAR_HTTP. BUG=666340 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Show an info icon with a tooltip for PSL-matches in the account chooser on Views. The actual icon is taken from LOCATION_BAR_HTTP. BUG=666340 ========== to ========== Show an info icon with a tooltip for PSL-matches in the account chooser on Views. The actual icon is taken from LOCATION_BAR_HTTP. BUG=666340 Committed: https://crrev.com/b35160455293212a373c044cf84494ca4ea75d58 Cr-Commit-Position: refs/heads/master@{#435613} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/b35160455293212a373c044cf84494ca4ea75d58 Cr-Commit-Position: refs/heads/master@{#435613} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
