Show an info icon with a tooltip for PSL-matches in the account chooser on Views.

chrome/browser/ui/views/passwords/credentials_item_view.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/passwords/credentials_item_view.h"
 
 #include "base/macros.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/ui/passwords/manage_passwords_view_utils.h"
 #include "chrome/grit/generated_resources.h"
 #include "chrome/grit/theme_resources.h"
 #include "components/autofill/core/common/password_form.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/gfx/canvas.h"
+#include "ui/gfx/color_palette.h"
 #include "ui/gfx/image/image.h"
 #include "ui/gfx/path.h"
+#include "ui/gfx/vector_icons_public.h"
 #include "ui/views/border.h"
+#include "ui/views/controls/button/vector_icon_button.h"
 #include "ui/views/controls/image_view.h"
 #include "ui/views/controls/label.h"
 #include "ui/views/layout/layout_constants.h"
 
 namespace {
 // The default spacing between the icon and text.
 const int kSpacing = 12;
 
 gfx::Size GetTextLabelsSize(const views::Label* upper_label,
                             const views::Label* lower_label) {
@@ skipping 34 matching lines @@
     views::ButtonListener* button_listener,
     const base::string16& upper_text,
     const base::string16& lower_text,
     SkColor hover_color,
     const autofill::PasswordForm* form,
     net::URLRequestContextGetter* request_context)
     : LabelButton(button_listener, base::string16()),
       form_(form),
       upper_label_(nullptr),
       lower_label_(nullptr),
+      info_button_(nullptr),
       hover_color_(hover_color),
       weak_ptr_factory_(this) {
   set_notify_enter_exit_on_child(true);
   // Create an image-view for the avatar. Make sure it ignores events so that
   // the parent can receive the events instead.
   image_view_ = new CircularImageView;
   image_view_->set_interactive(false);
   gfx::Image image = ResourceBundle::GetSharedInstance().GetImageNamed(
       IDR_PROFILE_AVATAR_PLACEHOLDER_LARGE);
   DCHECK(image.Width() >= kAvatarImageSize &&
@@ skipping 16 matching lines @@
   }
 
   if (!lower_text.empty()) {
     lower_label_ = new views::Label(
         lower_text, rb->GetFontList(ui::ResourceBundle::SmallFont));
     lower_label_->SetHorizontalAlignment(gfx::ALIGN_LEFT);
     lower_label_->SetMultiLine(true);
     AddChildView(lower_label_);
   }
 
+  if (form_->is_public_suffix_match) {
+    info_button_ = new views::VectorIconButton(this);
+    info_button_->SetIcon(gfx::VectorIconId::INFORMATION);
+    info_button_->SetTooltipText(
+        base::UTF8ToUTF16(form_->origin.GetOrigin().spec()));
+    AddChildView(info_button_);
+  }
+
   if (!upper_text.empty() && !lower_text.empty())
     SetAccessibleName(upper_text + base::ASCIIToUTF16("\n") + lower_text);
   else
     SetAccessibleName(upper_text + lower_text);
 
   SetFocusBehavior(FocusBehavior::ALWAYS);
 }
 
 CredentialsItemView::~CredentialsItemView() = default;
 
@@ skipping 48 matching lines @@
   int y_offset = (child_area.height() -
       (upper_size.height() + lower_size.height())) / 2;
   gfx::Point label_origin(image_origin.x() + image_size.width() + kSpacing,
                           child_area.origin().y() + y_offset);
   if (upper_label_)
     upper_label_->SetBoundsRect(gfx::Rect(label_origin, upper_size));
   if (lower_label_) {
     label_origin.Offset(0, upper_size.height());
     lower_label_->SetBoundsRect(gfx::Rect(label_origin, lower_size));
   }
+  if (info_button_) {
+    gfx::Rect icon_rect(child_area.top_right(),
+                        gfx::Size(kInfoIconSize, kInfoIconSize));
+    icon_rect.Offset(-kInfoIconSize, (child_area.height() - kInfoIconSize) / 2);

[Evan Stade, 2016/11/29 15:06:50]

I had a hard time reading this (the screenshot helped). Consider:

gfx::Rect(child_area.right() - kInfoIconSize, (child_area.height() -
kInfoIconSize) / 2, kInfoIconSize, kInfoIconSize);

or

info_button_->SizeToPreferredSize();
info_button_->SetPosition(gfx::Point(child_area.right() - info_button_->width(),
(child_area.height() - info_button_->height()) / 2));

[vasilii, 2016/11/29 17:23:03]

Done.

+    info_button_->SetBoundsRect(icon_rect);
+  }
 }
 
 void CredentialsItemView::OnPaint(gfx::Canvas* canvas) {
   if (state() == STATE_PRESSED || state() == STATE_HOVERED)
     canvas->DrawColor(hover_color_);
 
   LabelButton::OnPaint(canvas);
 }
+
+void CredentialsItemView::ButtonPressed(views::Button* sender,
+                                        const ui::Event& event) {
+  DCHECK(sender == info_button_);

[Evan Stade, 2016/11/29 15:06:50]

DCHECK_EQ

but why is this a button if you don't care if it's clicked? Why not just an
imageview with a tooltip? In fact it seems like you should be reusing
TooltipIcon as it's a very similar ui (your designer may or may not be aware of
that part of the autofill card unmasking prompt).

[vasilii, 2016/11/29 17:23:03]

Done. I'll ask the designer. I feel that many rows with (?) look worse than with
(i).

[vasilii, 2016/11/30 13:17:45]

Hwi said that the autofill dialog should switch to (i) and dark tooltip due to
Project Harmony :-P

+}
+
+SkColor CredentialsItemView::GetVectorIconBaseColor() const {
+  return gfx::kChromeIconGrey;
+}