Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 2532243003: Revert of Hook up views/widgets to AshDevToolsDOMAgent (Closed)

Created:
4 years ago by battre
Modified:
4 years ago
Reviewers:
Sarmad Hashmi, sadrul
CC:
chromium-reviews, kalyank, sadrul, pfeldman, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Hook up views/widgets to AshDevToolsDOMAgent (patchset #3 id:40001 of https://codereview.chromium.org/2529553002/ ) Reason for revert: Reverting due to a memory leak. See http://crbug.com/648701#c26 Original issue's description: > Hook up views/widgets to AshDevToolsDOMAgent > > - This CL adds AshDevToolsDOMAgent as an observer to all widgets and views. > The WidgetRemovalObserver is specifically to remove the RootView subtree, > while the ViewObserver is to update any other descendant views. > AddViewTree was created so that whenever any |view| is added, it can > be pushed to the frontend. > - Add tests for when views are inserted, removed, rearranged, > removed & inserted. > - Add test to check if a widget owned by a native widget is represented > properly in the DOM. > > BUG=648701 > > Committed: https://crrev.com/b4ce166c6eb7bf65dedbdb6947e23fbf2992e251 > Cr-Commit-Position: refs/heads/master@{#434863} TBR=sadrul@chromium.org,mhashmi@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=648701 Committed: https://crrev.com/f640d3cbd00447abe17877078f14c73ad6aca26d Cr-Commit-Position: refs/heads/master@{#434941}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -236 lines) Patch
M ash/common/devtools/ash_devtools_dom_agent.h View 5 chunks +2 lines, -17 lines 0 comments Download
M ash/common/devtools/ash_devtools_dom_agent.cc View 10 chunks +9 lines, -58 lines 0 comments Download
M ash/common/devtools/ash_devtools_unittest.cc View 4 chunks +0 lines, -161 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
battre
Created Revert of Hook up views/widgets to AshDevToolsDOMAgent
4 years ago (2016-11-29 09:44:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2532243003/1
4 years ago (2016-11-29 09:44:47 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 09:45:50 UTC) #5
commit-bot: I haz the power
4 years ago (2016-11-29 09:47:56 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f640d3cbd00447abe17877078f14c73ad6aca26d
Cr-Commit-Position: refs/heads/master@{#434941}

Powered by Google App Engine
This is Rietveld 408576698