Chromium Code Reviews
DescriptionRevert of Hook up views/widgets to AshDevToolsDOMAgent (patchset #3 id:40001 of https://codereview.chromium.org/2529553002/ )
Reason for revert:
Reverting due to a memory leak. See http://crbug.com/648701#c26
Original issue's description:
> Hook up views/widgets to AshDevToolsDOMAgent
>
> - This CL adds AshDevToolsDOMAgent as an observer to all widgets and views.
> The WidgetRemovalObserver is specifically to remove the RootView subtree,
> while the ViewObserver is to update any other descendant views.
> AddViewTree was created so that whenever any |view| is added, it can
> be pushed to the frontend.
> - Add tests for when views are inserted, removed, rearranged,
> removed & inserted.
> - Add test to check if a widget owned by a native widget is represented
> properly in the DOM.
>
> BUG=648701
>
> Committed: https://crrev.com/b4ce166c6eb7bf65dedbdb6947e23fbf2992e251
> Cr-Commit-Position: refs/heads/master@{#434863}
TBR=sadrul@chromium.org,mhashmi@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=648701
Committed: https://crrev.com/f640d3cbd00447abe17877078f14c73ad6aca26d
Cr-Commit-Position: refs/heads/master@{#434941}
Patch Set 1 #
Messages
Total messages: 7 (3 generated)
|
|||||||||||||||||||||||||||||||||||||