Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Side by Side Diff: ash/common/devtools/ash_devtools_dom_agent.h

Issue 2532243003: Revert of Hook up views/widgets to AshDevToolsDOMAgent (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | ash/common/devtools/ash_devtools_dom_agent.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef ASH_COMMON_DEVTOOLS_ASH_DEVTOOLS_DOM_AGENT_H_ 5 #ifndef ASH_COMMON_DEVTOOLS_ASH_DEVTOOLS_DOM_AGENT_H_
6 #define ASH_COMMON_DEVTOOLS_ASH_DEVTOOLS_DOM_AGENT_H_ 6 #define ASH_COMMON_DEVTOOLS_ASH_DEVTOOLS_DOM_AGENT_H_
7 7
8 #include "ash/common/wm_shell.h" 8 #include "ash/common/wm_shell.h"
9 #include "ash/common/wm_window_observer.h" 9 #include "ash/common/wm_window_observer.h"
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
11 #include "components/ui_devtools/DOM.h" 11 #include "components/ui_devtools/DOM.h"
12 #include "components/ui_devtools/devtools_base_agent.h" 12 #include "components/ui_devtools/devtools_base_agent.h"
13 #include "ui/views/view.h" 13 #include "ui/views/view.h"
14 #include "ui/views/view_observer.h"
15 #include "ui/views/widget/widget.h" 14 #include "ui/views/widget/widget.h"
16 #include "ui/views/widget/widget_removals_observer.h"
17 15
18 namespace ash { 16 namespace ash {
19 namespace devtools { 17 namespace devtools {
20 18
21 class ASH_EXPORT AshDevToolsDOMAgent 19 class ASH_EXPORT AshDevToolsDOMAgent
22 : public NON_EXPORTED_BASE(ui::devtools::UiDevToolsBaseAgent< 20 : public NON_EXPORTED_BASE(ui::devtools::UiDevToolsBaseAgent<
23 ui::devtools::protocol::DOM::Metainfo>), 21 ui::devtools::protocol::DOM::Metainfo>),
24 public WmWindowObserver, 22 public WmWindowObserver {
25 public views::WidgetRemovalsObserver,
26 public views::ViewObserver {
27 public: 23 public:
28 explicit AshDevToolsDOMAgent(ash::WmShell* shell); 24 explicit AshDevToolsDOMAgent(ash::WmShell* shell);
29 ~AshDevToolsDOMAgent() override; 25 ~AshDevToolsDOMAgent() override;
30 26
31 // DOM::Backend 27 // DOM::Backend
32 ui::devtools::protocol::Response disable() override; 28 ui::devtools::protocol::Response disable() override;
33 ui::devtools::protocol::Response getDocument( 29 ui::devtools::protocol::Response getDocument(
34 std::unique_ptr<ui::devtools::protocol::DOM::Node>* out_root) override; 30 std::unique_ptr<ui::devtools::protocol::DOM::Node>* out_root) override;
35 31
36 // WindowObserver 32 // WindowObserver
37 void OnWindowTreeChanging(WmWindow* window, 33 void OnWindowTreeChanging(WmWindow* window,
38 const TreeChangeParams& params) override; 34 const TreeChangeParams& params) override;
39 void OnWindowTreeChanged(WmWindow* window, 35 void OnWindowTreeChanged(WmWindow* window,
40 const TreeChangeParams& params) override; 36 const TreeChangeParams& params) override;
41 void OnWindowStackingChanged(WmWindow* window) override; 37 void OnWindowStackingChanged(WmWindow* window) override;
42 38
43 // views::WidgetRemovalsObserver
44 void OnWillRemoveView(views::Widget* widget, views::View* view) override;
45
46 // views::ViewObserver
47 void OnChildViewRemoved(views::View* view, views::View* parent) override;
48 void OnChildViewAdded(views::View* view) override;
49 void OnChildViewReordered(views::View*) override;
50
51 WmWindow* GetWindowFromNodeId(int nodeId); 39 WmWindow* GetWindowFromNodeId(int nodeId);
52 views::Widget* GetWidgetFromNodeId(int nodeId); 40 views::Widget* GetWidgetFromNodeId(int nodeId);
53 views::View* GetViewFromNodeId(int nodeId); 41 views::View* GetViewFromNodeId(int nodeId);
54 42
55 int GetNodeIdFromWindow(WmWindow* window); 43 int GetNodeIdFromWindow(WmWindow* window);
56 int GetNodeIdFromWidget(views::Widget* widget); 44 int GetNodeIdFromWidget(views::Widget* widget);
57 int GetNodeIdFromView(views::View* view); 45 int GetNodeIdFromView(views::View* view);
58 46
59 private: 47 private:
60 std::unique_ptr<ui::devtools::protocol::DOM::Node> BuildInitialTree(); 48 std::unique_ptr<ui::devtools::protocol::DOM::Node> BuildInitialTree();
61 std::unique_ptr<ui::devtools::protocol::DOM::Node> BuildTreeForWindow( 49 std::unique_ptr<ui::devtools::protocol::DOM::Node> BuildTreeForWindow(
62 WmWindow* window); 50 WmWindow* window);
63 std::unique_ptr<ui::devtools::protocol::DOM::Node> BuildTreeForRootWidget( 51 std::unique_ptr<ui::devtools::protocol::DOM::Node> BuildTreeForRootWidget(
64 views::Widget* widget); 52 views::Widget* widget);
65 std::unique_ptr<ui::devtools::protocol::DOM::Node> BuildTreeForView( 53 std::unique_ptr<ui::devtools::protocol::DOM::Node> BuildTreeForView(
66 views::View* view); 54 views::View* view);
67 55
68 void AddWindowTree(WmWindow* window); 56 void AddWindowTree(WmWindow* window);
69 // |remove_observer| ensures that we don't add a duplicate observer in any 57 // |remove_observer| ensures that we don't add a duplicate observer in any
70 // observer callback. For example, |remove_observer| is false when rebuilding 58 // observer callback. For example, |remove_observer| is false when rebuilding
71 // the tree in OnWindowStackingChanged so that the observer is not removed and 59 // the tree in OnWindowStackingChanged so that the observer is not removed and
72 // re-added, thus causing endless calls on the observer. 60 // re-added, thus causing endless calls on the observer.
73 void RemoveWindowTree(WmWindow* window, bool remove_observer); 61 void RemoveWindowTree(WmWindow* window, bool remove_observer);
74 void RemoveWindowNode(WmWindow* window, bool remove_observer); 62 void RemoveWindowNode(WmWindow* window, bool remove_observer);
75 63
76 // Don't need AddWidgetTree because |widget| will always be inside a window,
77 // so when windows are created, their widget nodes are created as well.
78 void RemoveWidgetTree(views::Widget* widget, bool remove_observer); 64 void RemoveWidgetTree(views::Widget* widget, bool remove_observer);
79 void RemoveWidgetNode(views::Widget* widget, bool remove_observer); 65 void RemoveWidgetNode(views::Widget* widget, bool remove_observer);
80 66
81 void AddViewTree(views::View* view);
82 void RemoveViewTree(views::View* view, 67 void RemoveViewTree(views::View* view,
83 views::View* parent, 68 views::View* parent,
84 bool remove_observer); 69 bool remove_observer);
85 void RemoveViewNode(views::View* view, 70 void RemoveViewNode(views::View* view,
86 views::View* parent, 71 views::View* parent,
87 bool remove_observer); 72 bool remove_observer);
88 73
89 void RemoveObservers(); 74 void RemoveObserverFromAllWindows();
90 void Reset(); 75 void Reset();
91 76
92 ash::WmShell* shell_; 77 ash::WmShell* shell_;
93 78
94 using WindowToNodeIdMap = std::unordered_map<WmWindow*, int>; 79 using WindowToNodeIdMap = std::unordered_map<WmWindow*, int>;
95 WindowToNodeIdMap window_to_node_id_map_; 80 WindowToNodeIdMap window_to_node_id_map_;
96 using NodeIdToWindowMap = std::unordered_map<int, WmWindow*>; 81 using NodeIdToWindowMap = std::unordered_map<int, WmWindow*>;
97 NodeIdToWindowMap node_id_to_window_map_; 82 NodeIdToWindowMap node_id_to_window_map_;
98 83
99 using WidgetToNodeIdMap = std::unordered_map<views::Widget*, int>; 84 using WidgetToNodeIdMap = std::unordered_map<views::Widget*, int>;
100 WidgetToNodeIdMap widget_to_node_id_map_; 85 WidgetToNodeIdMap widget_to_node_id_map_;
101 using NodeIdToWidgetMap = std::unordered_map<int, views::Widget*>; 86 using NodeIdToWidgetMap = std::unordered_map<int, views::Widget*>;
102 NodeIdToWidgetMap node_id_to_widget_map_; 87 NodeIdToWidgetMap node_id_to_widget_map_;
103 88
104 using ViewToNodeIdMap = std::unordered_map<views::View*, int>; 89 using ViewToNodeIdMap = std::unordered_map<views::View*, int>;
105 ViewToNodeIdMap view_to_node_id_map_; 90 ViewToNodeIdMap view_to_node_id_map_;
106 using NodeIdToViewMap = std::unordered_map<int, views::View*>; 91 using NodeIdToViewMap = std::unordered_map<int, views::View*>;
107 NodeIdToViewMap node_id_to_view_map_; 92 NodeIdToViewMap node_id_to_view_map_;
108 93
109 DISALLOW_COPY_AND_ASSIGN(AshDevToolsDOMAgent); 94 DISALLOW_COPY_AND_ASSIGN(AshDevToolsDOMAgent);
110 }; 95 };
111 96
112 } // namespace devtools 97 } // namespace devtools
113 } // namespace ash 98 } // namespace ash
114 99
115 #endif // ASH_COMMON_DEVTOOLS_ASH_DEVTOOLS_DOM_AGENT_H_ 100 #endif // ASH_COMMON_DEVTOOLS_ASH_DEVTOOLS_DOM_AGENT_H_
OLDNEW
« no previous file with comments | « no previous file | ash/common/devtools/ash_devtools_dom_agent.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698