Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 2532103003: Fix http/tests/cache random-order flakiness (Closed)

Created:
4 years ago by yhirano
Modified:
4 years ago
Reviewers:
hiroshige
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix http/tests/cache random-order flakiness post-image-to-verify.php touches a file to check if it has been loaded, but multiple tests use the file. This change fixes the issue by separating the temporary file. BUG=663865 Committed: https://crrev.com/9f7c2d8eddada5b0fe0b123312b4e041b67c3879 Cr-Commit-Position: refs/heads/master@{#435144}

Patch Set 1 #

Messages

Total messages: 13 (8 generated)
yhirano
4 years ago (2016-11-29 09:56:14 UTC) #4
hiroshige
lgtm. Just memo: I thought adding comments saying "Modify filename when you copy-and-paste" might be ...
4 years ago (2016-11-30 07:41:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2532103003/1
4 years ago (2016-11-30 07:46:13 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-30 07:54:47 UTC) #11
commit-bot: I haz the power
4 years ago (2016-11-30 07:56:24 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9f7c2d8eddada5b0fe0b123312b4e041b67c3879
Cr-Commit-Position: refs/heads/master@{#435144}

Powered by Google App Engine
This is Rietveld 408576698