Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/cache/post-with-cached-subresources.php

Issue 2532103003: Fix http/tests/cache random-order flakiness (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/http/tests/cache/post-with-cached-subresources.php
diff --git a/third_party/WebKit/LayoutTests/http/tests/cache/post-with-cached-subresources.php b/third_party/WebKit/LayoutTests/http/tests/cache/post-with-cached-subresources.php
index a9cc043e42df1d1495c426f6330c5f90cb665503..fb13f2c30456716b6540fafc746a74dedca8c71a 100644
--- a/third_party/WebKit/LayoutTests/http/tests/cache/post-with-cached-subresources.php
+++ b/third_party/WebKit/LayoutTests/http/tests/cache/post-with-cached-subresources.php
@@ -24,7 +24,7 @@ function logAndFinish(message)
{
document.getElementById("result").appendChild(document.createTextNode(message));
var xhr = new XMLHttpRequest;
- xhr.open("GET", "../resources/reset-temp-file.php?filename=post.tmp", false);
+ xhr.open("GET", "../resources/reset-temp-file.php?filename=post-with-cached-subresources.tmp", false);
xhr.send(null);
if (window.testRunner)
testRunner.notifyDone();
@@ -35,10 +35,10 @@ clearstatcache();
if ($_POST["submit"] == "finish") {
// The initial load of the image might have been done from the cache. In that case, touch the
// state file to indicate a load has already occurred.
- if (!file_exists(sys_get_temp_dir() . "/post.tmp")) {
+ if (!file_exists(sys_get_temp_dir() . "/post-with-cached-subresources.tmp")) {
echo "<script>";
echo "xhr = new XMLHttpRequest;";
- echo "xhr.open('GET', '../resources/touch-temp-file.php?filename=post.tmp', false);";
+ echo "xhr.open('GET', '../resources/touch-temp-file.php?filename=post-with-cached-subresources.tmp', false);";
echo "xhr.send(null);";
echo "</script>";
}
@@ -48,12 +48,12 @@ if ($_POST["submit"] == "finish") {
echo "if (window.internals)";
echo " window.internals.evictAllResources();";
echo "</script>";
- echo "<img src='resources/post-image-to-verify.php' onload=\"logAndFinish('PASS');\" onerror=\"logAndFinish('FAIL');\"></img>";
+ echo "<img src='resources/post-image-to-verify.php?filename=post-with-cached-subresources.tmp' onload=\"logAndFinish('PASS');\" onerror=\"logAndFinish('FAIL');\"></img>";
} else {
- echo "<form action='post-with-cached-subresources.php' method='post'>";
+ echo "<form action='post-with-cached-subresources.php?filename=post-with-cached-subresources.tmp' method='post'>";
echo "<input type='submit' id='submit' name='submit' value='finish'>";
echo "</form>";
- echo "<img src='resources/post-image-to-verify.php' onload=\"document.getElementById('submit').click();\" onerror=\"logAndFinish('FAIL on initial load');\"></img>";
+ echo "<img src='resources/post-image-to-verify.php?filename=post-with-cached-subresources.tmp' onload=\"document.getElementById('submit').click();\" onerror=\"logAndFinish('FAIL on initial load');\"></img>";
}
?>
</body>

Powered by Google App Engine
This is Rietveld 408576698