X87: [test] disable number-tostring test case for x87.

X87: [test] disable number-tostring test case for x87.

  The reason:
  The CL #41255 (https://codereview.chromium.org/2520363002 ) reimplemnt the Number.prototype.toString and the added number-tostring test cases failed at x87.

  Similar to many previos fixing CLs, i.e.: CL #37371 (https://codereview.chromium.org/2111493002 ), the root reason is:
  The Gcc compiler and it's dependent C++ libraris on linux platform use x87 in extended 80-bit double precision by default.
  So the reimplemented DoubleToRadixCString() will generate extended 80-bit double precision result which isn't the expected standard 64-bit double precision
  value.

  Although modifying DoubleToRadixCString() function to manually do the 80-bit <--> 64-bit conversion for each double/float computation step can fix this issue,
  but it wll drop the DoubleToRadixCString() function's performance of other architectures.

  This CL put the failed number-tostring test cases into number-tostring-big-integer.js and disables it for x87.

BUG=

Committed: https://crrev.com/0c6b6138bf7b3ebd407bef08ac2dedbeb7cdb881
Cr-Commit-Position: refs/heads/master@{#41322}

[zhengxing.li, 2016-11-28 10:52:49]

zhengxing.li@intel.com changed reviewers:
+ chunyang.dai@intel.com, yangguo@chromium.org

[zhengxing.li, 2016-11-28 10:52:49]

PTAL, thanks!

[Yang, 2016-11-28 10:58:02]

On 2016/11/28 10:52:49, zhengxing.li wrote:
> PTAL, thanks!

Can you factor out the items that fail into a stand-alone test and blacklist
only that test?

[zhengxing.li, 2016-11-28 13:58:45]

On 2016/11/28 10:58:02, Yang wrote:
> On 2016/11/28 10:52:49, zhengxing.li wrote:
> > PTAL, thanks!
> 
> Can you factor out the items that fail into a stand-alone test and blacklist
> only that test?

Thanks, Yang.

For latest code, the test in test/mjsunit/number-tostring.js: line 154  is the
only failed test.
The test is: 
assertEquals("314404114120101444444424000000000000000",(1.2345e+27).toString(5));


So you mean that I should put this test into an other new js file under
test/mjsunit folder and disable it?

Thanks!

[Yang, 2016-11-28 13:59:33]

On 2016/11/28 13:58:45, zhengxing.li wrote:
> On 2016/11/28 10:58:02, Yang wrote:
> > On 2016/11/28 10:52:49, zhengxing.li wrote:
> > > PTAL, thanks!
> > 
> > Can you factor out the items that fail into a stand-alone test and blacklist
> > only that test?
> 
> Thanks, Yang.
> 
> For latest code, the test in test/mjsunit/number-tostring.js: line 154  is the
> only failed test.
> The test is: 
>
assertEquals("314404114120101444444424000000000000000",(1.2345e+27).toString(5));
> 
> 
> So you mean that I should put this test into an other new js file under
> test/mjsunit folder and disable it?
> 
> Thanks!

yes. please do. thanks.

[zhengxing.li, 2016-11-28 14:00:39]

On 2016/11/28 13:59:33, Yang wrote:
> On 2016/11/28 13:58:45, zhengxing.li wrote:
> > On 2016/11/28 10:58:02, Yang wrote:
> > > On 2016/11/28 10:52:49, zhengxing.li wrote:
> > > > PTAL, thanks!
> > > 
> > > Can you factor out the items that fail into a stand-alone test and
blacklist
> > > only that test?
> > 
> > Thanks, Yang.
> > 
> > For latest code, the test in test/mjsunit/number-tostring.js: line 154  is
the
> > only failed test.
> > The test is: 
> >
>
assertEquals("314404114120101444444424000000000000000",(1.2345e+27).toString(5));
> > 
> > 
> > So you mean that I should put this test into an other new js file under
> > test/mjsunit folder and disable it?
> > 
> > Thanks!
> 
> yes. please do. thanks.

Got it, thanks!

[zhengxing.li, 2016-11-28 14:44:14]

Description was changed from

==========
X87: [test] disable number-tostring test case for x87.

  The reason:
  The CL #41255 (https://codereview.chromium.org/2520363002 ) reimplemnt the
Number.prototype.toString and the added number-tostring test cases failed at
x87.

  Similar to many previos fixing CLs, i.e.: CL #37371
(https://codereview.chromium.org/2111493002 ), the root reason is:
  The Gcc compiler and it's dependent C++ libraris on linux platform use x87 in
extended 80-bit double precision by default.
  So the reimplemented DoubleToRadixCString() will generate extended 80-bit
double precision result which isn't the expected standard 64-bit double
precision
  value.

  Although modifying DoubleToRadixCString() function to manually do the 80-bit
<--> 64-bit conversion for each double/float computation step can fix this
issue,
  but it wll drop the DoubleToRadixCString() function's performance of other
architectures.

  This CL disables number-tostring test cases for x87.

BUG=
==========

to

==========
X87: [test] disable number-tostring test case for x87.

  The reason:
  The CL #41255 (https://codereview.chromium.org/2520363002 ) reimplemnt the
Number.prototype.toString and the added number-tostring test cases failed at
x87.

  Similar to many previos fixing CLs, i.e.: CL #37371
(https://codereview.chromium.org/2111493002 ), the root reason is:
  The Gcc compiler and it's dependent C++ libraris on linux platform use x87 in
extended 80-bit double precision by default.
  So the reimplemented DoubleToRadixCString() will generate extended 80-bit
double precision result which isn't the expected standard 64-bit double
precision
  value.

  Although modifying DoubleToRadixCString() function to manually do the 80-bit
<--> 64-bit conversion for each double/float computation step can fix this
issue,
  but it wll drop the DoubleToRadixCString() function's performance of other
architectures.

  This CL put the failed number-tostring test cases into
number-tostring-big-integer.js and disables it for x87.

BUG=
==========

[zhengxing.li, 2016-11-28 14:46:07]

On 2016/11/28 14:00:39, zhengxing.li wrote:
> On 2016/11/28 13:59:33, Yang wrote:
> > On 2016/11/28 13:58:45, zhengxing.li wrote:
> > > On 2016/11/28 10:58:02, Yang wrote:
> > > > On 2016/11/28 10:52:49, zhengxing.li wrote:
> > > > > PTAL, thanks!
> > > > 
> > > > Can you factor out the items that fail into a stand-alone test and
> blacklist
> > > > only that test?
> > > 
> > > Thanks, Yang.
> > > 
> > > For latest code, the test in test/mjsunit/number-tostring.js: line 154  is
> the
> > > only failed test.
> > > The test is: 
> > >
> >
>
assertEquals("314404114120101444444424000000000000000",(1.2345e+27).toString(5));
> > > 
> > > 
> > > So you mean that I should put this test into an other new js file under
> > > test/mjsunit folder and disable it?
> > > 
> > > Thanks!
> > 
> > yes. please do. thanks.
> 
> Got it, thanks!

Hi, Yang:

I updated the CL and its description according to your suggestions, would you
please help to review it?

Thanks!

[Yang, 2016-11-28 14:49:33]

lgtm with nit.

https://codereview.chromium.org/2532073002/diff/20001/test/mjsunit/number-tos...
File test/mjsunit/number-tostring-big-integer.js (right):

https://codereview.chromium.org/2532073002/diff/20001/test/mjsunit/number-tos...
test/mjsunit/number-tostring-big-integer.js:33:
assertEquals("314404114120101444444424000000000000000",(1.2345e+27).toString(5));
please adhere to the 80 characters per line limit.

[zhengxing.li, 2016-11-28 14:57:53]

On 2016/11/28 14:49:33, Yang wrote:
> lgtm with nit.
> 
>
https://codereview.chromium.org/2532073002/diff/20001/test/mjsunit/number-tos...
> File test/mjsunit/number-tostring-big-integer.js (right):
> 
>
https://codereview.chromium.org/2532073002/diff/20001/test/mjsunit/number-tos...
> test/mjsunit/number-tostring-big-integer.js:33:
>
assertEquals("314404114120101444444424000000000000000",(1.2345e+27).toString(5));
> please adhere to the 80 characters per line limit.

Hi, Yang:

>
https://codereview.chromium.org/2532073002/diff/20001/test/mjsunit/number-tos...
> test/mjsunit/number-tostring-big-integer.js:33:
>
assertEquals("314404114120101444444424000000000000000",(1.2345e+27).toString(5));
> please adhere to the 80 characters per line limit.
Done!

Thanks!

[zhengxing.li, 2016-11-28 15:04:16]

The CQ bit was checked by zhengxing.li@intel.com

[zhengxing.li, 2016-11-28 15:04:17]

The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/2532073002/#ps40001
(title: "adhere to the 80 characters per line limit.")

[commit-bot: I haz the power, 2016-11-28 15:04:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 15:31:09]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480345456623710,
"parent_rev": "13a6f9f4c056512e23e0010384b590620f66a9da", "commit_rev":
"ffccffba1ba9eea61290f540bc3dbe5a73d7457d"}

[commit-bot: I haz the power, 2016-11-28 15:31:12]

Description was changed from

==========
X87: [test] disable number-tostring test case for x87.

  The reason:
  The CL #41255 (https://codereview.chromium.org/2520363002 ) reimplemnt the
Number.prototype.toString and the added number-tostring test cases failed at
x87.

  Similar to many previos fixing CLs, i.e.: CL #37371
(https://codereview.chromium.org/2111493002 ), the root reason is:
  The Gcc compiler and it's dependent C++ libraris on linux platform use x87 in
extended 80-bit double precision by default.
  So the reimplemented DoubleToRadixCString() will generate extended 80-bit
double precision result which isn't the expected standard 64-bit double
precision
  value.

  Although modifying DoubleToRadixCString() function to manually do the 80-bit
<--> 64-bit conversion for each double/float computation step can fix this
issue,
  but it wll drop the DoubleToRadixCString() function's performance of other
architectures.

  This CL put the failed number-tostring test cases into
number-tostring-big-integer.js and disables it for x87.

BUG=
==========

to

==========
X87: [test] disable number-tostring test case for x87.

  The reason:
  The CL #41255 (https://codereview.chromium.org/2520363002 ) reimplemnt the
Number.prototype.toString and the added number-tostring test cases failed at
x87.

  Similar to many previos fixing CLs, i.e.: CL #37371
(https://codereview.chromium.org/2111493002 ), the root reason is:
  The Gcc compiler and it's dependent C++ libraris on linux platform use x87 in
extended 80-bit double precision by default.
  So the reimplemented DoubleToRadixCString() will generate extended 80-bit
double precision result which isn't the expected standard 64-bit double
precision
  value.

  Although modifying DoubleToRadixCString() function to manually do the 80-bit
<--> 64-bit conversion for each double/float computation step can fix this
issue,
  but it wll drop the DoubleToRadixCString() function's performance of other
architectures.

  This CL put the failed number-tostring test cases into
number-tostring-big-integer.js and disables it for x87.

BUG=
==========

[commit-bot: I haz the power, 2016-11-28 15:31:13]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-28 15:31:27]

Description was changed from

==========
X87: [test] disable number-tostring test case for x87.

  The reason:
  The CL #41255 (https://codereview.chromium.org/2520363002 ) reimplemnt the
Number.prototype.toString and the added number-tostring test cases failed at
x87.

  Similar to many previos fixing CLs, i.e.: CL #37371
(https://codereview.chromium.org/2111493002 ), the root reason is:
  The Gcc compiler and it's dependent C++ libraris on linux platform use x87 in
extended 80-bit double precision by default.
  So the reimplemented DoubleToRadixCString() will generate extended 80-bit
double precision result which isn't the expected standard 64-bit double
precision
  value.

  Although modifying DoubleToRadixCString() function to manually do the 80-bit
<--> 64-bit conversion for each double/float computation step can fix this
issue,
  but it wll drop the DoubleToRadixCString() function's performance of other
architectures.

  This CL put the failed number-tostring test cases into
number-tostring-big-integer.js and disables it for x87.

BUG=
==========

to

==========
X87: [test] disable number-tostring test case for x87.

  The reason:
  The CL #41255 (https://codereview.chromium.org/2520363002 ) reimplemnt the
Number.prototype.toString and the added number-tostring test cases failed at
x87.

  Similar to many previos fixing CLs, i.e.: CL #37371
(https://codereview.chromium.org/2111493002 ), the root reason is:
  The Gcc compiler and it's dependent C++ libraris on linux platform use x87 in
extended 80-bit double precision by default.
  So the reimplemented DoubleToRadixCString() will generate extended 80-bit
double precision result which isn't the expected standard 64-bit double
precision
  value.

  Although modifying DoubleToRadixCString() function to manually do the 80-bit
<--> 64-bit conversion for each double/float computation step can fix this
issue,
  but it wll drop the DoubleToRadixCString() function's performance of other
architectures.

  This CL put the failed number-tostring test cases into
number-tostring-big-integer.js and disables it for x87.

BUG=

Committed: https://crrev.com/0c6b6138bf7b3ebd407bef08ac2dedbeb7cdb881
Cr-Commit-Position: refs/heads/master@{#41322}
==========

[commit-bot: I haz the power, 2016-11-28 15:31:28]

Patchset 3 (id:??) landed as
https://crrev.com/0c6b6138bf7b3ebd407bef08ac2dedbeb7cdb881
Cr-Commit-Position: refs/heads/master@{#41322}