X87: disable some sin/cos/expm1/tan test cases for x87.

X87: disable some sin/cos/expm1/tan test cases for x87.

  The reason:
  All RunFloat64Sin/RunFloat64Cos/RunFloat64Expm1/RunFloat64Tan/Ieee754.Expm1/Ieee754.Cos/Ieee754.Tan test cases
  use the C++ function to generate the expected value or result. So for x87, all those expected value or result are
  extended double precision as the extended double precision is default for x87 Gcc compiler and std lib on linux platform.

  The issue is:
  For RunFloat64Sin/RunFloat64Cos/RunFloat64Expm1/RunFloat64Tan test cases, the expected values generated by C++ function
  are extended double precision, the results generated by X87 jitted code are double precision according to the ECMA standard.
  The comparison of different precisons caused some of those test cases failed.

  For Ieee754.Expm1/Ieee754.Cos/Ieee754.Tan test cases, the expected values are pre-defined double precision values, the results
  generated by C++ function are extended double precision. The comparison of different precisons caused some of those test cases
  failed too.

  This CL disables RunFloat64Sin/RunFloat64Cos/RunFloat64Expm1/RunFloat64Tan/Ieee754.Expm1/Ieee754.Cos/Ieee754.Tan test cases for x87.

BUG=

Committed: https://crrev.com/9a9ffd1370dbf91c7f56c0b556a89fb5701c2201
Cr-Commit-Position: refs/heads/master@{#37371}

[zhengxing.li, 2016-06-29 07:52:52]

zhengxing.li@intel.com changed reviewers:
+ bmeurer@chromium.org, chunyang.dai@intel.com, titzer@chromium.org,
weiliang.lin@intel.com

[zhengxing.li, 2016-06-29 07:52:52]

PTAL, thanks!

[titzer, 2016-06-29 08:07:26]

lgtm

Is there a plan for fixing these implementations on x87?

[zhengxing.li, 2016-06-29 08:28:16]

On 2016/06/29 08:07:26, titzer wrote:
> lgtm
> 
> Is there a plan for fixing these implementations on x87?

Thanks!

It's hard to fix these implementations on x87. Because extended double precision
is default for x87 Gcc compiler and std library.

I tried other solutions such as: use -ffloat-store gcc compile option or set the
x87 FPU precision to double precision. 

Although those solutions can fix all these disabled test cases, it will cause
other test cases fail and the error message is very strange and
not easy to aware it's a precision problem, it's hard for the future x87 port
maintain.

[zhengxing.li, 2016-06-29 08:28:38]

The CQ bit was checked by zhengxing.li@intel.com

[commit-bot: I haz the power, 2016-06-29 08:28:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 09:00:22]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-29 09:02:59]

Description was changed from

==========
X87: disable some sin/cos/expm1/tan test cases for x87.

  The reason:
  All
RunFloat64Sin/RunFloat64Cos/RunFloat64Expm1/RunFloat64Tan/Ieee754.Expm1/Ieee754.Cos/Ieee754.Tan
test cases
  use the C++ function to generate the expected value or result. So for x87, all
those expected value or result are
  extended double precision as the extended double precision is default for x87
Gcc compiler and std lib on linux platform.

  The issue is:
  For RunFloat64Sin/RunFloat64Cos/RunFloat64Expm1/RunFloat64Tan test cases, the
expected values generated by C++ function
  are extended double precision, the results generated by X87 jitted code are
double precision according to the ECMA standard.
  The comparison of different precisons caused some of those test cases failed.

  For Ieee754.Expm1/Ieee754.Cos/Ieee754.Tan test cases, the expected values are
pre-defined double precision values, the results
  generated by C++ function are extended double precision. The comparison of
different precisons caused some of those test cases
  failed too.

  This CL disables
RunFloat64Sin/RunFloat64Cos/RunFloat64Expm1/RunFloat64Tan/Ieee754.Expm1/Ieee754.Cos/Ieee754.Tan
test cases for x87.

BUG=
==========

to

==========
X87: disable some sin/cos/expm1/tan test cases for x87.

  The reason:
  All
RunFloat64Sin/RunFloat64Cos/RunFloat64Expm1/RunFloat64Tan/Ieee754.Expm1/Ieee754.Cos/Ieee754.Tan
test cases
  use the C++ function to generate the expected value or result. So for x87, all
those expected value or result are
  extended double precision as the extended double precision is default for x87
Gcc compiler and std lib on linux platform.

  The issue is:
  For RunFloat64Sin/RunFloat64Cos/RunFloat64Expm1/RunFloat64Tan test cases, the
expected values generated by C++ function
  are extended double precision, the results generated by X87 jitted code are
double precision according to the ECMA standard.
  The comparison of different precisons caused some of those test cases failed.

  For Ieee754.Expm1/Ieee754.Cos/Ieee754.Tan test cases, the expected values are
pre-defined double precision values, the results
  generated by C++ function are extended double precision. The comparison of
different precisons caused some of those test cases
  failed too.

  This CL disables
RunFloat64Sin/RunFloat64Cos/RunFloat64Expm1/RunFloat64Tan/Ieee754.Expm1/Ieee754.Cos/Ieee754.Tan
test cases for x87.

BUG=

Committed: https://crrev.com/9a9ffd1370dbf91c7f56c0b556a89fb5701c2201
Cr-Commit-Position: refs/heads/master@{#37371}
==========

[commit-bot: I haz the power, 2016-06-29 09:03:00]

Patchset 1 (id:??) landed as
https://crrev.com/9a9ffd1370dbf91c7f56c0b556a89fb5701c2201
Cr-Commit-Position: refs/heads/master@{#37371}