Return virtual braille display size as columns and rows, not text count.

Return virtual braille display size as columns and rows, not text count.

This was causing the braille captions to not show up since change r431444.

BUG=669255
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/6775eaa66fd603752e718d1ddd734c0c209bca8e
Cr-Commit-Position: refs/heads/master@{#435048}

[dmazzoni, 2016-11-28 23:09:47]

Description was changed from

==========
Return virtual braille display size as columns and rows, not text count.

This was causing the braille captions to not show up since change r431444.

BUG=669255
==========

to

==========
Return virtual braille display size as columns and rows, not text count.

This was causing the braille captions to not show up since change r431444.

BUG=669255
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dmazzoni, 2016-11-28 23:10:02]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[dmazzoni, 2016-11-28 23:10:22]

dmazzoni@chromium.org changed reviewers:
+ ultimatedbz@google.com

[commit-bot: I haz the power, 2016-11-28 23:11:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ultimatedbz, 2016-11-28 23:40:29]

https://codereview.chromium.org/2532003004/diff/1/chrome/browser/resources/ch...
File
chrome/browser/resources/chromeos/chromevox/chromevox/background/braille_captions_background.js
(right):

https://codereview.chromium.org/2532003004/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/chromevox/background/braille_captions_background.js:145:
textRowCount: 1,
Should we change 1 and 40 to
parseInt(localStorage['virtualbraille[Rows/Columns]'], 10)? This change isn't
needed right now because everything is still laid out in one line, and it is
only in the panel, when localStorage is accessed. At that point, it manually
adds new rows to the table to simulate line breaks. If you are okay with this,
as what I proposed won't be needed until the word wrapping code, then it lgtm!

[commit-bot: I haz the power, 2016-11-29 02:13:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 02:13:46]

Dry run: This issue passed the CQ dry run.

[dmazzoni, 2016-11-29 18:11:33]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2016-11-29 18:11:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
ultimatedbz@google.com
Link to the patchset: https://codereview.chromium.org/2532003004/#ps20001
(title: "Use localStorage['virtualBrailleRows'], etc")

[commit-bot: I haz the power, 2016-11-29 18:11:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 19:11:13]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480443093928890,
"parent_rev": "209cc37c498564330f443ba96fec30a3cc435a6c", "commit_rev":
"ac7d24c06e5b56b96916cf00eb6a667cb93522a4"}

[commit-bot: I haz the power, 2016-11-29 19:11:43]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-29 19:17:04]

Description was changed from

==========
Return virtual braille display size as columns and rows, not text count.

This was causing the braille captions to not show up since change r431444.

BUG=669255
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Return virtual braille display size as columns and rows, not text count.

This was causing the braille captions to not show up since change r431444.

BUG=669255
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/6775eaa66fd603752e718d1ddd734c0c209bca8e
Cr-Commit-Position: refs/heads/master@{#435048}
==========

[commit-bot: I haz the power, 2016-11-29 19:17:05]

Patchset 2 (id:??) landed as
https://crrev.com/6775eaa66fd603752e718d1ddd734c0c209bca8e
Cr-Commit-Position: refs/heads/master@{#435048}