Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2159)

Unified Diff: chrome/browser/resources/chromeos/chromevox/chromevox/background/braille_captions_background.js

Issue 2532003004: Return virtual braille display size as columns and rows, not text count. (Closed)
Patch Set: Use localStorage['virtualBrailleRows'], etc Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/chromeos/chromevox/chromevox/background/braille_captions_background.js
diff --git a/chrome/browser/resources/chromeos/chromevox/chromevox/background/braille_captions_background.js b/chrome/browser/resources/chromeos/chromevox/chromevox/background/braille_captions_background.js
index 47fdd0e6188fbcf8dd084a40458f9f63cb398c53..a1d1cc198c9b3218e6ec7f62b07416913d95b5f9 100644
--- a/chrome/browser/resources/chromeos/chromevox/chromevox/background/braille_captions_background.js
+++ b/chrome/browser/resources/chromeos/chromevox/chromevox/background/braille_captions_background.js
@@ -141,7 +141,9 @@ cvox.BrailleCaptionsBackground.setActive = function(newValue) {
cvox.BrailleCaptionsBackground.getVirtualDisplayState = function() {
var self = cvox.BrailleCaptionsBackground;
if (self.isEnabled()) {
- return {available: true, textCellCount: 40}; // 40, why not?
+ var rows = parseInt(localStorage['virtualBrailleRows'], 10) || 1;
+ var columns = parseInt(localStorage['virtualBrailleColumns'], 10) || 40;
+ return {available: true, textRowCount: rows, textColumnCount: columns};
} else {
return {available: false};
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698