Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2532003002: MutationObserver: Fix a null-pointer dereference in MutationObserverRegistration::unregister. (Closed)

Created:
4 years ago by tkent
Modified:
4 years ago
Reviewers:
keishi
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MutationObserver: Fix a null-pointer dereference in MutationObserverRegistration::unregister. Before Oilpan was enabled, MutationObserverRegistration couldn't outlive m_registrationNode. After enabling Oilpan, it's possible that a MutationObserverRegsitration outlives its m_registrationNode. Reproducible scenario: - No Persistent/Member references to both of objects, - No pointer to the m_registrationNode on the stack, - A pointer to the MutationObserveRegistration exists on the stack, and - Conservative GC is executed. BUG=657613 Committed: https://crrev.com/afe73aec9717475be1979d3a052cb3fd81da8e17 Cr-Commit-Position: refs/heads/master@{#434616}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -6 lines) Patch
M third_party/WebKit/Source/core/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/MutationCallback.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/MutationObserver.h View 3 chunks +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/MutationObserverRegistration.h View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/MutationObserverRegistration.cpp View 1 chunk +5 lines, -4 lines 0 comments Download
A third_party/WebKit/Source/core/dom/MutationObserverTest.cpp View 1 chunk +60 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (16 generated)
tkent
Keishi@, can you review this? This is a regression by Oilpan.
4 years ago (2016-11-28 07:12:06 UTC) #12
keishi
LGTM
4 years ago (2016-11-28 07:56:38 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2532003002/40001
4 years ago (2016-11-28 08:03:56 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years ago (2016-11-28 08:08:20 UTC) #19
commit-bot: I haz the power
4 years ago (2016-11-28 08:10:53 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/afe73aec9717475be1979d3a052cb3fd81da8e17
Cr-Commit-Position: refs/heads/master@{#434616}

Powered by Google App Engine
This is Rietveld 408576698