third_party/WebKit/Source/core/dom/MutationObserverRegistration.cpp - Issue 2532003002: MutationObserver: Fix a null-pointer dereference in MutationObserverRegistration::unregister.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/MutationObserverRegistration.cpp

Issue 2532003002: MutationObserver: Fix a null-pointer dereference in MutationObserverRegistration::unregister. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/MutationObserverRegistration.h ('k') | third_party/WebKit/Source/core/dom/MutationObserverTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/MutationObserverRegistration.cpp

diff --git a/third_party/WebKit/Source/core/dom/MutationObserverRegistration.cpp b/third_party/WebKit/Source/core/dom/MutationObserverRegistration.cpp

index e92b88a62ea344cbb8b2dfd9e05111b86480deeb..86bd65c37289fddbfa6b4b383112f11897d029f9 100644

--- a/third_party/WebKit/Source/core/dom/MutationObserverRegistration.cpp

+++ b/third_party/WebKit/Source/core/dom/MutationObserverRegistration.cpp

@@ -107,10 +107,11 @@ void MutationObserverRegistration::clearTransientRegistrations() {

}

void MutationObserverRegistration::unregister() {

- DCHECK(m_registrationNode);

- m_registrationNode->unregisterMutationObserver(this);

- // The above line will cause this object to be deleted, so don't do any more

- // in this function.

+ // |this| can outlives m_registrationNode.

+ if (m_registrationNode)

+ m_registrationNode->unregisterMutationObserver(this);

+ else

+ dispose();

}

bool MutationObserverRegistration::shouldReceiveMutationFrom(