Issue 253183002: Revert 266967 "Merge 266651 "linux-aura: Supports Compose key wi..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 253183002: Revert 266967 "Merge 266651 "linux-aura: Supports Compose key wi..." (Closed)

Created:
6 years, 7 months ago by Elliot Glaysher

Modified:
6 years, 7 months ago

Reviewers:
Elliot Glaysher

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 266967 "Merge 266651 "linux-aura: Supports Compose key wi..." Compile failure: ../../ui/events/x/events_x.cc: In function ‘int {anonymous}::GetEventFlagsFromXKeyEvent(XEvent*)’: ../../ui/events/x/events_x.cc:172:51: error: ‘IsKeypadKey’ was not declared in this scope > Merge 266651 "linux-aura: Supports Compose key with XIM." > > > linux-aura: Supports Compose key with XIM. > > > > Supports Compose key with XIM and makes .XCompose settings effective with Linux Aura build. > > > > BUG=351230, 360388, 349163 > > TEST=Done manually. Tested with GTK_IM_MODULE=xim XMODIFIERS=@im=none and ~/.XCompose with custom contents. > > R=erg@chromium.org, sadrul@chromium.org > > > > Review URL: https://codereview.chromium.org/243143002 > > TBR=piman@chromium.org,yukishiino@chromium.org > > Review URL: https://codereview.chromium.org/260573002 TBR=erg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266978

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -48 lines)			Patch
M	branches/1916/src/chrome/browser/ui/libgtk2ui/x11_input_method_context_impl_gtk2.h	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	branches/1916/src/chrome/browser/ui/libgtk2ui/x11_input_method_context_impl_gtk2.cc	View	3 chunks	+2 lines, -7 lines	0 comments	Download
M	branches/1916/src/ui/aura/window_targeter.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	branches/1916/src/ui/base/ime/input_method_auralinux.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	branches/1916/src/ui/events/event_constants.h	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	branches/1916/src/ui/events/x/events_x.cc	View	1 chunk	+0 lines, -25 lines	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r266978.