Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 260573002: Merge 266651 "linux-aura: Supports Compose key with XIM." (Closed)

Created:
6 years, 7 months ago by Elliot Glaysher
Modified:
6 years, 7 months ago
Reviewers:
piman
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, penghuang+watch_chromium.org, nona+watch_chromium.org, kalyank, ben+aura_chromium.org, James Su
Visibility:
Public.

Description

Merge 266651 "linux-aura: Supports Compose key with XIM." > linux-aura: Supports Compose key with XIM. > > Supports Compose key with XIM and makes .XCompose settings effective with Linux Aura build. > > BUG=351230, 360388, 349163 > TEST=Done manually. Tested with GTK_IM_MODULE=xim XMODIFIERS=@im=none and ~/.XCompose with custom contents. > R=erg@chromium.org, sadrul@chromium.org > > Review URL: https://codereview.chromium.org/243143002 TBR=piman@chromium.org,yukishiino@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266967

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -4 lines) Patch
M chrome/browser/ui/libgtk2ui/x11_input_method_context_impl_gtk2.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/libgtk2ui/x11_input_method_context_impl_gtk2.cc View 3 chunks +7 lines, -2 lines 0 comments Download
M ui/aura/window_targeter.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/base/ime/input_method_auralinux.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/events/event_constants.h View 1 chunk +8 lines, -0 lines 0 comments Download
M ui/events/x/events_x.cc View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Elliot Glaysher
6 years, 7 months ago (2014-04-29 21:57:16 UTC) #1
Elliot Glaysher
6 years, 7 months ago (2014-04-29 21:59:01 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r266967.

Powered by Google App Engine
This is Rietveld 408576698