Revert of Post tasks for sensitive input visibility notifications

Revert of Post tasks for sensitive input visibility notifications (patchset #5 id:80001 of https://codereview.chromium.org/2515373003/ )

Reason for revert:
Suspected for flaky failures on browser_tests for Mac 10.9 asan, Mac 10.10

E.g.
SecurityStateTabHelperTestWithPasswordCcSwitch/SecurityStateTabHelperTestWithPasswordCcSwitch.PasswordSecurityLevelDowngradedFromIframe/0
SecurityStateTabHelperTest.PasswordSecurityLevelNotDowngradedWithoutSwitch

https://uberchromegw.corp.google.com/i/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/24682
https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.10%20Tests/builds/9716

Errors like

../../chrome/browser/ssl/security_state_tab_helper_browser_tests.cc:966: Failure
Value of: security_info.security_level
  Actual: 0
Expected: security_state::HTTP_SHOW_WARNING
Which is: 1
../../chrome/browser/ssl/security_state_tab_helper_browser_tests.cc:971: Failure
Value of: entry->GetSSL().content_status & content::SSLStatus::DISPLAYED_PASSWORD_FIELD_ON_HTTP
  Actual: false
Expected: true

Original issue's description:
> Post tasks for sensitive input visibility notifications
>
> If password inputs are hidden and shown multiple times in the same task
> (as apparently happens when processing a stylesheet), we don't want to
> the omnibox warning to flicker in and out. Thus, this CL posts sensitive
> input visibility notifications to the end of the task queue, so that the
> omnibox warning updates get coalesced.
>
> BUG=664194
> TEST=Visit http://http-password.badssl.com and observe that the omnibox
> warning does not flicker in and out twice.
>
> Committed: https://crrev.com/7bdbe352cdbd7cc1dec2b71653e60b47688bd9e1
> Cr-Commit-Position: refs/heads/master@{#434340}

TBR=dcheng@chromium.org,haraken@chromium.org,estark@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=664194
Committed: https://crrev.com/e0c7eb5a36b45db9a17c75715a99b3a547c45974
Cr-Commit-Position: refs/heads/master@{#434400}

[tapted, 2016-11-24 22:25:20]

The CQ bit was checked by tapted@chromium.org

[tapted, 2016-11-24 22:25:21]

Created Revert of Post tasks for sensitive input visibility notifications

[commit-bot: I haz the power, 2016-11-24 22:25:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-24 22:26:08]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1480026320869630, "parent_rev":
"e12052411c156738a5309f89fa2392c3effaa619", "commit_rev":
"c9621ddf25810b84cb993c773ed9b75602e60332"}

[commit-bot: I haz the power, 2016-11-24 22:26:32]

Description was changed from

==========
Revert of Post tasks for sensitive input visibility notifications (patchset #5
id:80001 of https://codereview.chromium.org/2515373003/ )

Reason for revert:
Suspected for flaky failures on browser_tests for Mac 10.9 asan, Mac 10.10

E.g.
SecurityStateTabHelperTestWithPasswordCcSwitch/SecurityStateTabHelperTestWithPasswordCcSwitch.PasswordSecurityLevelDowngradedFromIframe/0
SecurityStateTabHelperTest.PasswordSecurityLevelNotDowngradedWithoutSwitch

https://uberchromegw.corp.google.com/i/chromium.memory/builders/Mac%20ASan%20...
https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.10%20Tests...

Errors like

../../chrome/browser/ssl/security_state_tab_helper_browser_tests.cc:966: Failure
Value of: security_info.security_level
  Actual: 0
Expected: security_state::HTTP_SHOW_WARNING
Which is: 1
../../chrome/browser/ssl/security_state_tab_helper_browser_tests.cc:971: Failure
Value of: entry->GetSSL().content_status &
content::SSLStatus::DISPLAYED_PASSWORD_FIELD_ON_HTTP
  Actual: false
Expected: true

Original issue's description:
> Post tasks for sensitive input visibility notifications
> 
> If password inputs are hidden and shown multiple times in the same task
> (as apparently happens when processing a stylesheet), we don't want to
> the omnibox warning to flicker in and out. Thus, this CL posts sensitive
> input visibility notifications to the end of the task queue, so that the
> omnibox warning updates get coalesced.
> 
> BUG=664194
> TEST=Visit http://http-password.badssl.com and observe that the omnibox
> warning does not flicker in and out twice.
> 
> Committed: https://crrev.com/7bdbe352cdbd7cc1dec2b71653e60b47688bd9e1
> Cr-Commit-Position: refs/heads/master@{#434340}

TBR=dcheng@chromium.org,haraken@chromium.org,estark@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=664194
==========

to

==========
Revert of Post tasks for sensitive input visibility notifications (patchset #5
id:80001 of https://codereview.chromium.org/2515373003/ )

Reason for revert:
Suspected for flaky failures on browser_tests for Mac 10.9 asan, Mac 10.10

E.g.
SecurityStateTabHelperTestWithPasswordCcSwitch/SecurityStateTabHelperTestWithPasswordCcSwitch.PasswordSecurityLevelDowngradedFromIframe/0
SecurityStateTabHelperTest.PasswordSecurityLevelNotDowngradedWithoutSwitch

https://uberchromegw.corp.google.com/i/chromium.memory/builders/Mac%20ASan%20...
https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.10%20Tests...

Errors like

../../chrome/browser/ssl/security_state_tab_helper_browser_tests.cc:966: Failure
Value of: security_info.security_level
  Actual: 0
Expected: security_state::HTTP_SHOW_WARNING
Which is: 1
../../chrome/browser/ssl/security_state_tab_helper_browser_tests.cc:971: Failure
Value of: entry->GetSSL().content_status &
content::SSLStatus::DISPLAYED_PASSWORD_FIELD_ON_HTTP
  Actual: false
Expected: true

Original issue's description:
> Post tasks for sensitive input visibility notifications
> 
> If password inputs are hidden and shown multiple times in the same task
> (as apparently happens when processing a stylesheet), we don't want to
> the omnibox warning to flicker in and out. Thus, this CL posts sensitive
> input visibility notifications to the end of the task queue, so that the
> omnibox warning updates get coalesced.
> 
> BUG=664194
> TEST=Visit http://http-password.badssl.com and observe that the omnibox
> warning does not flicker in and out twice.
> 
> Committed: https://crrev.com/7bdbe352cdbd7cc1dec2b71653e60b47688bd9e1
> Cr-Commit-Position: refs/heads/master@{#434340}

TBR=dcheng@chromium.org,haraken@chromium.org,estark@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=664194
==========

[commit-bot: I haz the power, 2016-11-24 22:26:33]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-24 22:29:05]

Description was changed from

==========
Revert of Post tasks for sensitive input visibility notifications (patchset #5
id:80001 of https://codereview.chromium.org/2515373003/ )

Reason for revert:
Suspected for flaky failures on browser_tests for Mac 10.9 asan, Mac 10.10

E.g.
SecurityStateTabHelperTestWithPasswordCcSwitch/SecurityStateTabHelperTestWithPasswordCcSwitch.PasswordSecurityLevelDowngradedFromIframe/0
SecurityStateTabHelperTest.PasswordSecurityLevelNotDowngradedWithoutSwitch

https://uberchromegw.corp.google.com/i/chromium.memory/builders/Mac%20ASan%20...
https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.10%20Tests...

Errors like

../../chrome/browser/ssl/security_state_tab_helper_browser_tests.cc:966: Failure
Value of: security_info.security_level
  Actual: 0
Expected: security_state::HTTP_SHOW_WARNING
Which is: 1
../../chrome/browser/ssl/security_state_tab_helper_browser_tests.cc:971: Failure
Value of: entry->GetSSL().content_status &
content::SSLStatus::DISPLAYED_PASSWORD_FIELD_ON_HTTP
  Actual: false
Expected: true

Original issue's description:
> Post tasks for sensitive input visibility notifications
> 
> If password inputs are hidden and shown multiple times in the same task
> (as apparently happens when processing a stylesheet), we don't want to
> the omnibox warning to flicker in and out. Thus, this CL posts sensitive
> input visibility notifications to the end of the task queue, so that the
> omnibox warning updates get coalesced.
> 
> BUG=664194
> TEST=Visit http://http-password.badssl.com and observe that the omnibox
> warning does not flicker in and out twice.
> 
> Committed: https://crrev.com/7bdbe352cdbd7cc1dec2b71653e60b47688bd9e1
> Cr-Commit-Position: refs/heads/master@{#434340}

TBR=dcheng@chromium.org,haraken@chromium.org,estark@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=664194
==========

to

==========
Revert of Post tasks for sensitive input visibility notifications (patchset #5
id:80001 of https://codereview.chromium.org/2515373003/ )

Reason for revert:
Suspected for flaky failures on browser_tests for Mac 10.9 asan, Mac 10.10

E.g.
SecurityStateTabHelperTestWithPasswordCcSwitch/SecurityStateTabHelperTestWithPasswordCcSwitch.PasswordSecurityLevelDowngradedFromIframe/0
SecurityStateTabHelperTest.PasswordSecurityLevelNotDowngradedWithoutSwitch

https://uberchromegw.corp.google.com/i/chromium.memory/builders/Mac%20ASan%20...
https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.10%20Tests...

Errors like

../../chrome/browser/ssl/security_state_tab_helper_browser_tests.cc:966: Failure
Value of: security_info.security_level
  Actual: 0
Expected: security_state::HTTP_SHOW_WARNING
Which is: 1
../../chrome/browser/ssl/security_state_tab_helper_browser_tests.cc:971: Failure
Value of: entry->GetSSL().content_status &
content::SSLStatus::DISPLAYED_PASSWORD_FIELD_ON_HTTP
  Actual: false
Expected: true

Original issue's description:
> Post tasks for sensitive input visibility notifications
>
> If password inputs are hidden and shown multiple times in the same task
> (as apparently happens when processing a stylesheet), we don't want to
> the omnibox warning to flicker in and out. Thus, this CL posts sensitive
> input visibility notifications to the end of the task queue, so that the
> omnibox warning updates get coalesced.
>
> BUG=664194
> TEST=Visit http://http-password.badssl.com and observe that the omnibox
> warning does not flicker in and out twice.
>
> Committed: https://crrev.com/7bdbe352cdbd7cc1dec2b71653e60b47688bd9e1
> Cr-Commit-Position: refs/heads/master@{#434340}

TBR=dcheng@chromium.org,haraken@chromium.org,estark@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=664194

Committed: https://crrev.com/e0c7eb5a36b45db9a17c75715a99b3a547c45974
Cr-Commit-Position: refs/heads/master@{#434400}
==========

[commit-bot: I haz the power, 2016-11-24 22:29:06]

Patchset 1 (id:??) landed as
https://crrev.com/e0c7eb5a36b45db9a17c75715a99b3a547c45974
Cr-Commit-Position: refs/heads/master@{#434400}

[haraken, 2016-11-24 23:29:18]

LGTM to revert

[estark, 2016-11-28 17:33:14]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2538473002/ by estark@chromium.org.

The reason for reverting is: Fixing SecuritySTateTabHelperTests.