Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Unified Diff: third_party/WebKit/Source/core/dom/Document.cpp

Issue 2531683002: Revert of Post tasks for sensitive input visibility notifications (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/Document.cpp
diff --git a/third_party/WebKit/Source/core/dom/Document.cpp b/third_party/WebKit/Source/core/dom/Document.cpp
index b002d54e76a7c94b8516322116657275008dd926..c44b227186644837c5a4a628e8e496940d1075d4 100644
--- a/third_party/WebKit/Source/core/dom/Document.cpp
+++ b/third_party/WebKit/Source/core/dom/Document.cpp
@@ -241,13 +241,11 @@
#include "platform/weborigin/OriginAccessEntry.h"
#include "platform/weborigin/SchemeRegistry.h"
#include "platform/weborigin/SecurityOrigin.h"
-#include "public/platform/InterfaceProvider.h"
#include "public/platform/Platform.h"
#include "public/platform/WebAddressSpace.h"
#include "public/platform/WebFrameScheduler.h"
#include "public/platform/WebPrerenderingSupport.h"
#include "public/platform/WebScheduler.h"
-#include "public/platform/modules/sensitive_input_visibility/sensitive_input_visibility_service.mojom-blink.h"
#include "wtf/AutoReset.h"
#include "wtf/CurrentTime.h"
#include "wtf/DateMath.h"
@@ -4331,32 +4329,6 @@
return *m_accessEntryFromURL;
}
-void Document::sendSensitiveInputVisibility() {
- if (m_sensitiveInputVisibilityTask.isActive())
- return;
-
- m_sensitiveInputVisibilityTask =
- TaskRunnerHelper::get(TaskType::Internal, this)
- ->postCancellableTask(
- BLINK_FROM_HERE,
- WTF::bind(&Document::sendSensitiveInputVisibilityInternal,
- wrapWeakPersistent(this)));
-}
-
-void Document::sendSensitiveInputVisibilityInternal() {
- if (!frame())
- return;
-
- mojom::blink::SensitiveInputVisibilityServicePtr sensitiveInputServicePtr;
- frame()->interfaceProvider()->getInterface(
- mojo::GetProxy(&sensitiveInputServicePtr));
- if (m_passwordCount > 0) {
- sensitiveInputServicePtr->PasswordFieldVisibleInInsecureContext();
- return;
- }
- sensitiveInputServicePtr->AllPasswordFieldsInInsecureContextInvisible();
-}
-
void Document::registerEventFactory(
std::unique_ptr<EventFactoryBase> eventFactory) {
DCHECK(!eventFactories().contains(eventFactory.get()));
@@ -6434,26 +6406,15 @@
void Document::incrementPasswordCount() {
++m_passwordCount;
- if (isSecureContext() || m_passwordCount != 1) {
- // The browser process only cares about passwords on pages where the
- // top-level URL is not secure. Secure contexts must have a top-level
- // URL that is secure, so there is no need to send notifications for
- // password fields in secure contexts.
- //
- // Also, only send a message on the first visible password field; the
- // browser process doesn't care about the presence of additional
- // password fields beyond that.
- return;
- }
- sendSensitiveInputVisibility();
}
void Document::decrementPasswordCount() {
DCHECK_GT(m_passwordCount, 0u);
--m_passwordCount;
- if (isSecureContext() || m_passwordCount > 0)
- return;
- sendSensitiveInputVisibility();
+}
+
+unsigned Document::passwordCount() const {
+ return m_passwordCount;
}
DEFINE_TRACE(Document) {
« no previous file with comments | « third_party/WebKit/Source/core/dom/Document.h ('k') | third_party/WebKit/Source/core/html/forms/PasswordInputType.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698