third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp - Issue 2531603003: Only scroll on main if the targeted frames need to scroll on main

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp

Issue 2531603003: Only scroll on main if the targeted frames need to scroll on main (Closed)

Patch Set: Resolve conflict Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp b/third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp

index 7e022a42b2eabb0f0b29719a3d16f0b2ced210ff..24bdf713dc49dc96cec156c32d75146a0d685a4c 100644

--- a/third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp

+++ b/third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp

@@ -496,7 +496,9 @@ TEST_F(FrameThrottlingTest, ScrollingCoordinatorShouldSkipThrottledFrame) {

compositeFrame();

EXPECT_FALSE(frameElement->contentDocument()->view()->canThrottleRendering());

// The fixed background in the throttled sub frame should be considered.

- EXPECT_TRUE(document().view()->shouldScrollOnMainThread());

+ EXPECT_TRUE(

+ frameElement->contentDocument()->view()->shouldScrollOnMainThread());

+ EXPECT_FALSE(document().view()->shouldScrollOnMainThread());

}

TEST_F(FrameThrottlingTest, ScrollingCoordinatorShouldSkipThrottledLayer) {