third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp - Issue 2531603003: Only scroll on main if the targeted frames need to scroll on main

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp

Issue 2531603003: Only scroll on main if the targeted frames need to scroll on main (Closed)

Patch Set: Resolve conflict Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp

diff --git a/third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp b/third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp

index 80d99f47401e5e6706fd17573c088818f038b8dc..65c2fb1cef9e720bfe6be7f6e010b4b8dd0388a1 100644

--- a/third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp

+++ b/third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp

@@ -361,6 +361,8 @@ void ScrollAnimator::updateCompositorAnimations() {

}

void ScrollAnimator::addMainThreadScrollingReason() {

+ // TODO(yigu): Should update the frame tree to make sure

+ // the same reason is set for subframes. crbug.com/675677.

if (WebLayer* scrollLayer =

toWebLayer(getScrollableArea()->layerForScrolling())) {

scrollLayer->addMainThreadScrollingReasons(