third_party/WebKit/Source/core/page/Page.h - Issue 2531603003: Only scroll on main if the targeted frames need to scroll on main

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/Page.h

Issue 2531603003: Only scroll on main if the targeted frames need to scroll on main (Closed)

Patch Set: Update sub-frame using loops instead of recursion & integrate a patch to fix spv2 problem Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/page/Page.h

diff --git a/third_party/WebKit/Source/core/page/Page.h b/third_party/WebKit/Source/core/page/Page.h

index 69e603bfc81921b7e1cc668dbaa8ee6dc62ee935..27f16dba1dd750b5acb79c8db5441a6d96f8993b 100644

--- a/third_party/WebKit/Source/core/page/Page.h

+++ b/third_party/WebKit/Source/core/page/Page.h

@@ -171,7 +171,7 @@ class CORE_EXPORT Page final : public GarbageCollectedFinalized<Page>,

ScrollingCoordinator* scrollingCoordinator();

- String mainThreadScrollingReasonsAsText();

+ String mainThreadScrollingReasonsAsText(Frame*);

pdr. 2016/12/07 22:25:29 nit: String mainThreadScrollingReasonsAsText(const

yigu 2016/12/08 18:52:29 This function cannot be const as it calls Page::sc

ClientRectList* nonFastScrollableRects(const LocalFrame*);

Settings& settings() const { return *m_settings; }