third_party/WebKit/Source/core/frame/FrameView.cpp - Issue 2531603003: Only scroll on main if the targeted frames need to scroll on main

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2531603003: Only scroll on main if the targeted frames need to scroll on main (Closed)

Patch Set: Update sub-frame using loops instead of recursion & integrate a patch to fix spv2 problem Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/FrameView.cpp

diff --git a/third_party/WebKit/Source/core/frame/FrameView.cpp b/third_party/WebKit/Source/core/frame/FrameView.cpp

index 8f14f007e448d32c2a6764b3b3b04a6adad430ce..ce09e0c7e4411a47529559b3a1c4bf5bdd378b47 100644

--- a/third_party/WebKit/Source/core/frame/FrameView.cpp

+++ b/third_party/WebKit/Source/core/frame/FrameView.cpp

@@ -825,7 +825,7 @@ bool FrameView::usesCompositedScrolling() const {

bool FrameView::shouldScrollOnMainThread() const {

if (ScrollingCoordinator* sc = scrollingCoordinator()) {

- if (sc->shouldUpdateScrollLayerPositionOnMainThread())

+ if (sc->shouldUpdateScrollLayerPositionOnMainThread(m_frame))

return true;

}

return ScrollableArea::shouldScrollOnMainThread();