Convert chart-json to Histograms.

Convert chart-json to Histograms.

Currently, TBMv1 benchmarks and other scripts produce chart-json,
which cannot be displayed by results2.html.

This CL implements ConvertChartJson(), which converts chart-json to
single-bin Histograms with IterationInfo diagnostics.

HtmlOutputFormatter is now unused. If there are no complaints, then it and its
template can be deleted.

https://screenshot.googleplex.com/omepkp6EUPN.png

Legacy units and what to do about them:
https://docs.google.com/spreadsheets/d/1poCtwvaIsXiPQWKGYkz4iOTk6XErpAJPO6aZMykNHwU/edit

Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/4b8ce174b7ef489bd850983f3897b5d2bf8cbf33

[benjhayden, 2016-11-02 04:46:51]

Patchset #1 (id:1) has been deleted

[benjhayden, 2016-11-02 04:47:17]

Patchset #1 (id:20001) has been deleted

[benjhayden, 2016-11-02 05:05:45]

Patchset #1 (id:40001) has been deleted

[benjhayden, 2016-11-02 05:16:23]

benjhayden@chromium.org changed reviewers:
+ eakuefner@chromium.org, nednguyen@google.com

[benjhayden, 2016-11-02 05:16:23]

Obviously, convert_chart_json.html isn't quite done yet, but I think this is
surprisingly close to producing results2.html all the time.

I think we'd need another CL after this one to generalize map_single_trace to
map_single_file, which we can then use to write a tool that reads chart-json
from a file, converts it to histograms, then writes them to a new histogram-json
file. We might never actually need that tool depending on how the rest of the
pipeline works, but it seems like it might be at least occasionally useful while
we still have chart-json floating around.

Do you see any problems yet?

I'll work more on convert_chart_json.html after I get some sleep.

[benjhayden, 2016-11-02 05:26:38]

On 2016/11/02 at 05:16:23, benjhayden wrote:
> Obviously, convert_chart_json.html isn't quite done yet, but I think this is
surprisingly close to producing results2.html all the time.
> 
> I think we'd need another CL after this one to generalize map_single_trace to
map_single_file, which we can then use to write a tool that reads chart-json
from a file, converts it to histograms, then writes them to a new histogram-json
file. We might never actually need that tool depending on how the rest of the
pipeline works, but it seems like it might be at least occasionally useful while
we still have chart-json floating around.

Sorry, we can just use vinn.RunFile, we don't need map_single_file, do we?

> 
> Do you see any problems yet?
> 
> I'll work more on convert_chart_json.html after I get some sleep.

[benjhayden, 2016-11-02 18:02:10]

Description was changed from

==========
Convert chart-json to Histograms.
==========

to

==========
Convert chart-json to Histograms.

Currently, TBMv1 benchmarks and other scripts produce results in chart-json
format.
results2 cannot display chart-json.

This CL implements convertChartJson(), which converts chart-json dictionaries to
single-bin Histograms with IterationInfo diagnostics.

convertChartJson() is then used in results2_template.html to allow
Html2OutputFormatter to support TBMv1 benchmarks.

convert_chart_json.py and tracing/bin/chartjson2histograms are provided as
utilities
that may or may not become necessary depending on the steps of the easiest path
to
getting Histograms everywhere.
==========

[benjhayden, 2016-11-02 18:11:57]

Patchset #1 (id:60001) has been deleted

[benjhayden, 2016-11-02 18:12:01]

Patchset #1 (id:80001) has been deleted

[benjhayden, 2016-11-02 18:18:30]

Description was changed from

==========
Convert chart-json to Histograms.

Currently, TBMv1 benchmarks and other scripts produce results in chart-json
format.
results2 cannot display chart-json.

This CL implements convertChartJson(), which converts chart-json dictionaries to
single-bin Histograms with IterationInfo diagnostics.

convertChartJson() is then used in results2_template.html to allow
Html2OutputFormatter to support TBMv1 benchmarks.

convert_chart_json.py and tracing/bin/chartjson2histograms are provided as
utilities
that may or may not become necessary depending on the steps of the easiest path
to
getting Histograms everywhere.
==========

to

==========
Convert chart-json to Histograms.

Currently, TBMv1 benchmarks and other scripts produce results in chart-json
format.
results2 cannot display chart-json.

This CL implements convertChartJson(), which converts chart-json dictionaries to
single-bin Histograms with IterationInfo diagnostics.

convertChartJson() is then used in results2_template.html to allow
Html2OutputFormatter to support TBMv1 benchmarks.

HtmlOutputFormatter is now unused. If there are no complaints, then it and its
template can be deleted.

convert_chart_json.py and tracing/bin/chartjson2histograms are provided as
utilities
that may or may not be temporarily necessary depending on the steps of the
easiest path to getting Histograms everywhere, but will probably be useful for
debugging while there are still scripts that produce chart-json.
==========

[benjhayden, 2016-11-02 23:08:37]

Description was changed from

==========
Convert chart-json to Histograms.

Currently, TBMv1 benchmarks and other scripts produce results in chart-json
format.
results2 cannot display chart-json.

This CL implements convertChartJson(), which converts chart-json dictionaries to
single-bin Histograms with IterationInfo diagnostics.

convertChartJson() is then used in results2_template.html to allow
Html2OutputFormatter to support TBMv1 benchmarks.

HtmlOutputFormatter is now unused. If there are no complaints, then it and its
template can be deleted.

convert_chart_json.py and tracing/bin/chartjson2histograms are provided as
utilities
that may or may not be temporarily necessary depending on the steps of the
easiest path to getting Histograms everywhere, but will probably be useful for
debugging while there are still scripts that produce chart-json.
==========

to

==========
Convert telemetry value json to Histograms.

Currently, TBMv1 benchmarks and other scripts produce TBMv1 Values, which have
their own JSON format, which cannot be displayed by results2.html.

This CL implements convertTelemetryJson(), which converts telemetry Value json
to
single-bin Histograms with IterationInfo diagnostics.

Html2OutputFormatter and ValueSetOutputFormatter pass TBMv1 Value json through
vinn to convert them to Histograms before serializing them.

HtmlOutputFormatter is now unused. If there are no complaints, then it and its
template can be deleted.
==========

[benjhayden, 2016-11-02 23:10:12]

Hold review while I pivot from chart-json to telemetry-json.

[nednguyen, 2016-11-02 23:12:18]

On 2016/11/02 23:10:12, benjhayden wrote:
> Hold review while I pivot from chart-json to telemetry-json.

Why telemetry json? I thought you want chart-json converter because that enables
converting the results of other uploaders?

[benjhayden, 2016-11-03 00:17:11]

On 2016/11/02 at 23:12:18, nednguyen wrote:
> On 2016/11/02 23:10:12, benjhayden wrote:
> > Hold review while I pivot from chart-json to telemetry-json.
> 
> Why telemetry json? I thought you want chart-json converter because that
enables converting the results of other uploaders?

That was the idea, but what are the non-telemetry producers of chart-json?
Also, Ethan pointed out today that the chart-json format is difficult to
interpret because it is ambiguous.

[benjhayden, 2016-11-03 20:06:28]

Description was changed from

==========
Convert telemetry value json to Histograms.

Currently, TBMv1 benchmarks and other scripts produce TBMv1 Values, which have
their own JSON format, which cannot be displayed by results2.html.

This CL implements convertTelemetryJson(), which converts telemetry Value json
to
single-bin Histograms with IterationInfo diagnostics.

Html2OutputFormatter and ValueSetOutputFormatter pass TBMv1 Value json through
vinn to convert them to Histograms before serializing them.

HtmlOutputFormatter is now unused. If there are no complaints, then it and its
template can be deleted.
==========

to

==========
Convert chart-json to Histograms.

Currently, TBMv1 benchmarks and other scripts produce TBMv1 Values, which have
their own JSON format, which cannot be displayed by results2.html.

This CL implements convertTelemetryJson(), which converts telemetry Value json
to
single-bin Histograms with IterationInfo diagnostics.

Html2OutputFormatter and ValueSetOutputFormatter pass TBMv1 Value json through
vinn to convert them to Histograms before serializing them.

HtmlOutputFormatter is now unused. If there are no complaints, then it and its
template can be deleted.
==========

[benjhayden, 2016-11-03 20:09:46]

Description was changed from

==========
Convert chart-json to Histograms.

Currently, TBMv1 benchmarks and other scripts produce TBMv1 Values, which have
their own JSON format, which cannot be displayed by results2.html.

This CL implements convertTelemetryJson(), which converts telemetry Value json
to
single-bin Histograms with IterationInfo diagnostics.

Html2OutputFormatter and ValueSetOutputFormatter pass TBMv1 Value json through
vinn to convert them to Histograms before serializing them.

HtmlOutputFormatter is now unused. If there are no complaints, then it and its
template can be deleted.
==========

to

==========
Convert chart-json to Histograms.

Currently, TBMv1 benchmarks and other scripts produce TBMv1 Values, which have
their own JSON format, which cannot be displayed by results2.html.

This CL implements convertChartJson(), which converts chart-json to
single-bin Histograms with IterationInfo diagnostics.

Html2OutputFormatter and ValueSetOutputFormatter pass TBMv1 Value json through
vinn to convert them to Histograms before serializing them.

HtmlOutputFormatter is now unused. If there are no complaints, then it and its
template can be deleted.
==========

[benjhayden, 2016-11-03 20:11:15]

Description was changed from

==========
Convert chart-json to Histograms.

Currently, TBMv1 benchmarks and other scripts produce TBMv1 Values, which have
their own JSON format, which cannot be displayed by results2.html.

This CL implements convertChartJson(), which converts chart-json to
single-bin Histograms with IterationInfo diagnostics.

Html2OutputFormatter and ValueSetOutputFormatter pass TBMv1 Value json through
vinn to convert them to Histograms before serializing them.

HtmlOutputFormatter is now unused. If there are no complaints, then it and its
template can be deleted.
==========

to

==========
Convert chart-json to Histograms.

Currently, TBMv1 benchmarks and other scripts produce chart-json,
which cannot be displayed by results2.html.

This CL implements convertChartJson(), which converts chart-json to
single-bin Histograms with IterationInfo diagnostics.

Html2OutputFormatter and ValueSetOutputFormatter pass TBMv1 Value json through
vinn to convert them to Histograms before serializing them.

HtmlOutputFormatter is now unused. If there are no complaints, then it and its
template can be deleted.
==========

[benjhayden, 2016-11-03 20:21:25]

On 2016/11/03 at 00:17:11, benjhayden wrote:
> On 2016/11/02 at 23:12:18, nednguyen wrote:
> > On 2016/11/02 23:10:12, benjhayden wrote:
> > > Hold review while I pivot from chart-json to telemetry-json.
> > 
> > Why telemetry json? I thought you want chart-json converter because that
enables converting the results of other uploaders?
> 
> That was the idea, but what are the non-telemetry producers of chart-json?
> Also, Ethan pointed out today that the chart-json format is difficult to
interpret because it is ambiguous.

Sorry, flop, nevermind.

PTAL :-)

[nednguyen, 2016-11-03 21:10:24]

https://codereview.chromium.org/2474573002/diff/100001/tracing/bin/chartjson2...
File tracing/bin/chartjson2histograms (right):

https://codereview.chromium.org/2474573002/diff/100001/tracing/bin/chartjson2...
tracing/bin/chartjson2histograms:28:
histograms.extend(json.load(file(args.histogram_json, 'r')))
This could be confusing to people that if they run the command twice, they get
the histograms duplicated.

Is there any reason why you support appending? If not, I would just always write
to the file

https://codereview.chromium.org/2474573002/diff/100001/tracing/tracing/result...
File tracing/tracing/results2_template.html (right):

https://codereview.chromium.org/2474573002/diff/100001/tracing/tracing/result...
tracing/tracing/results2_template.html:1: <!DOCTYPE html>
nits: maybe we can just rename this to results_template (in a different CL)

https://codereview.chromium.org/2474573002/diff/100001/tracing/tracing/result...
File tracing/tracing/results_renderer.py (right):

https://codereview.chromium.org/2474573002/diff/100001/tracing/tracing/result...
tracing/tracing/results_renderer.py:56: def RenderHTMLView(histograms, charts,
output_stream, reset_results=False):
I would split this to two different function, one that handle histograms & one
that handle charts. It's pretty weird that one would have both

https://codereview.chromium.org/2474573002/diff/100001/tracing/tracing/result...
File tracing/tracing/results_renderer_unittest.py (right):

https://codereview.chromium.org/2474573002/diff/100001/tracing/tracing/result...
tracing/tracing/results_renderer_unittest.py:37: 
add test coverage for ReadExistingChartJson?

https://codereview.chromium.org/2474573002/diff/100001/tracing/tracing/value/...
File tracing/tracing/value/convert_chart_json.html (right):

https://codereview.chromium.org/2474573002/diff/100001/tracing/tracing/value/...
tracing/tracing/value/convert_chart_json.html:1: <!DOCTYPE html>
nits: name this chart_json_converter.html 

I think most file names are noun, not verb.

https://codereview.chromium.org/2474573002/diff/100001/tracing/tracing/value/...
tracing/tracing/value/convert_chart_json.html:23: var unit =
tr.b.Unit.byName.unitlessNumber;
this doesn't seem right. ChartJson can contain existing units in them, IIRC

https://codereview.chromium.org/2474573002/diff/100001/tracing/tracing/value/...
File tracing/tracing/value/convert_chart_json.py (right):

https://codereview.chromium.org/2474573002/diff/100001/tracing/tracing/value/...
tracing/tracing/value/convert_chart_json.py:1: #!/usr/bin/env python
ditto

[benjhayden, 2016-11-09 22:38:44]

Description was changed from

==========
Convert chart-json to Histograms.

Currently, TBMv1 benchmarks and other scripts produce chart-json,
which cannot be displayed by results2.html.

This CL implements convertChartJson(), which converts chart-json to
single-bin Histograms with IterationInfo diagnostics.

Html2OutputFormatter and ValueSetOutputFormatter pass TBMv1 Value json through
vinn to convert them to Histograms before serializing them.

HtmlOutputFormatter is now unused. If there are no complaints, then it and its
template can be deleted.
==========

to

==========
Convert chart-json to Histograms.

Currently, TBMv1 benchmarks and other scripts produce chart-json,
which cannot be displayed by results2.html.

This CL implements convertChartJson(), which converts chart-json to
single-bin Histograms with IterationInfo diagnostics.

Html2OutputFormatter and ValueSetOutputFormatter pass TBMv1 Value json through
vinn to convert them to Histograms before serializing them.

HtmlOutputFormatter is now unused. If there are no complaints, then it and its
template can be deleted.

https://screenshot.googleplex.com/omepkp6EUPN.png
==========

[benjhayden, 2016-11-09 22:39:31]

Description was changed from

==========
Convert chart-json to Histograms.

Currently, TBMv1 benchmarks and other scripts produce chart-json,
which cannot be displayed by results2.html.

This CL implements convertChartJson(), which converts chart-json to
single-bin Histograms with IterationInfo diagnostics.

Html2OutputFormatter and ValueSetOutputFormatter pass TBMv1 Value json through
vinn to convert them to Histograms before serializing them.

HtmlOutputFormatter is now unused. If there are no complaints, then it and its
template can be deleted.

https://screenshot.googleplex.com/omepkp6EUPN.png
==========

to

==========
Convert chart-json to Histograms.

Currently, TBMv1 benchmarks and other scripts produce chart-json,
which cannot be displayed by results2.html.

This CL implements convertChartJson(), which converts chart-json to
single-bin Histograms with IterationInfo diagnostics.

Html2OutputFormatter and ValueSetOutputFormatter pass TBMv1 Value json through
vinn to convert them to Histograms before serializing them.

HtmlOutputFormatter is now unused. If there are no complaints, then it and its
template can be deleted.

https://screenshot.googleplex.com/omepkp6EUPN.png

Legacy units and what to do about them:
https://docs.google.com/spreadsheets/d/1poCtwvaIsXiPQWKGYkz4iOTk6XErpAJPO6aZM...
==========

[benjhayden, 2016-11-09 23:48:55]

I still need to write some tests, otherwise PTAL.

https://codereview.chromium.org/2474573002/diff/100001/tracing/bin/chartjson2...
File tracing/bin/chartjson2histograms (right):

https://codereview.chromium.org/2474573002/diff/100001/tracing/bin/chartjson2...
tracing/bin/chartjson2histograms:28:
histograms.extend(json.load(file(args.histogram_json, 'r')))
On 2016/11/03 at 21:10:24, nednguyen wrote:
> This could be confusing to people that if they run the command twice, they get
the histograms duplicated.
> 
> Is there any reason why you support appending? If not, I would just always
write to the file

valueset2html reads existing results from the output file.

https://codereview.chromium.org/2474573002/diff/100001/tracing/tracing/result...
File tracing/tracing/results2_template.html (right):

https://codereview.chromium.org/2474573002/diff/100001/tracing/tracing/result...
tracing/tracing/results2_template.html:1: <!DOCTYPE html>
On 2016/11/03 at 21:10:24, nednguyen wrote:
> nits: maybe we can just rename this to results_template (in a different CL)

Maybe after HtmlOutputFormatter and its template are deleted?

https://codereview.chromium.org/2474573002/diff/100001/tracing/tracing/result...
File tracing/tracing/results_renderer.py (right):

https://codereview.chromium.org/2474573002/diff/100001/tracing/tracing/result...
tracing/tracing/results_renderer.py:56: def RenderHTMLView(histograms, charts,
output_stream, reset_results=False):
On 2016/11/03 at 21:10:24, nednguyen wrote:
> I would split this to two different function, one that handle histograms & one
that handle charts. It's pretty weird that one would have both

Sorry, I don't see how that would work?
This function vulcanizes results2_template, then writes the chart-json then the
histograms.
RenderChartJsonHtml() would have to vulcanize results2_template then the
chart-json; RenderHistogramsHtml would have to vulcanize results2_template then
the histograms; calling both on the same file would vulcanize twice, right?

https://codereview.chromium.org/2474573002/diff/100001/tracing/tracing/value/...
File tracing/tracing/value/convert_chart_json.html (right):

https://codereview.chromium.org/2474573002/diff/100001/tracing/tracing/value/...
tracing/tracing/value/convert_chart_json.html:1: <!DOCTYPE html>
On 2016/11/03 at 21:10:24, nednguyen wrote:
> nits: name this chart_json_converter.html 
> 
> I think most file names are noun, not verb.

Done.

https://codereview.chromium.org/2474573002/diff/100001/tracing/tracing/value/...
tracing/tracing/value/convert_chart_json.html:23: var unit =
tr.b.Unit.byName.unitlessNumber;
On 2016/11/03 at 21:10:24, nednguyen wrote:
> this doesn't seem right. ChartJson can contain existing units in them, IIRC

Yes, sorry, I hadn't finished the unit mapping. PTAL.

https://codereview.chromium.org/2474573002/diff/100001/tracing/tracing/value/...
File tracing/tracing/value/convert_chart_json.py (right):

https://codereview.chromium.org/2474573002/diff/100001/tracing/tracing/value/...
tracing/tracing/value/convert_chart_json.py:1: #!/usr/bin/env python
On 2016/11/03 at 21:10:24, nednguyen wrote:
> ditto

compare_samples.py?

[benjhayden, 2016-11-10 00:23:22]

Description was changed from

==========
Convert chart-json to Histograms.

Currently, TBMv1 benchmarks and other scripts produce chart-json,
which cannot be displayed by results2.html.

This CL implements convertChartJson(), which converts chart-json to
single-bin Histograms with IterationInfo diagnostics.

Html2OutputFormatter and ValueSetOutputFormatter pass TBMv1 Value json through
vinn to convert them to Histograms before serializing them.

HtmlOutputFormatter is now unused. If there are no complaints, then it and its
template can be deleted.

https://screenshot.googleplex.com/omepkp6EUPN.png

Legacy units and what to do about them:
https://docs.google.com/spreadsheets/d/1poCtwvaIsXiPQWKGYkz4iOTk6XErpAJPO6aZM...
==========

to

==========
Convert chart-json to Histograms.

Currently, TBMv1 benchmarks and other scripts produce chart-json,
which cannot be displayed by results2.html.

This CL implements convertChartJson(), which converts chart-json to
single-bin Histograms with IterationInfo diagnostics.

HtmlOutputFormatter is now unused. If there are no complaints, then it and its
template can be deleted.

https://screenshot.googleplex.com/omepkp6EUPN.png

Legacy units and what to do about them:
https://docs.google.com/spreadsheets/d/1poCtwvaIsXiPQWKGYkz4iOTk6XErpAJPO6aZM...
==========

[nednguyen, 2016-11-10 15:55:27]

Description was changed from

==========
Convert chart-json to Histograms.

Currently, TBMv1 benchmarks and other scripts produce chart-json,
which cannot be displayed by results2.html.

This CL implements convertChartJson(), which converts chart-json to
single-bin Histograms with IterationInfo diagnostics.

HtmlOutputFormatter is now unused. If there are no complaints, then it and its
template can be deleted.

https://screenshot.googleplex.com/omepkp6EUPN.png

Legacy units and what to do about them:
https://docs.google.com/spreadsheets/d/1poCtwvaIsXiPQWKGYkz4iOTk6XErpAJPO6aZM...
==========

to

==========
Convert chart-json to Histograms.

Currently, TBMv1 benchmarks and other scripts produce chart-json,
which cannot be displayed by results2.html.

This CL implements convertChartJson(), which converts chart-json to
single-bin Histograms with IterationInfo diagnostics.

HtmlOutputFormatter is now unused. If there are no complaints, then it and its
template can be deleted.

https://screenshot.googleplex.com/omepkp6EUPN.png

Legacy units and what to do about them:
https://docs.google.com/spreadsheets/d/1poCtwvaIsXiPQWKGYkz4iOTk6XErpAJPO6aZM...
==========

[nednguyen, 2016-11-10 15:55:28]

nednguyen@google.com changed reviewers:
+ sullivan@chromium.org
- nednguyen@google.com

[eakuefner, 2016-11-18 21:37:11]

lgtm % more tests

https://codereview.chromium.org/2474573002/diff/280001/tracing/bin/chartjson2...
File tracing/bin/chartjson2histograms (right):

https://codereview.chromium.org/2474573002/diff/280001/tracing/bin/chartjson2...
tracing/bin/chartjson2histograms:1: #!/usr/bin/env python
no need

https://codereview.chromium.org/2474573002/diff/280001/tracing/tracing/result...
File tracing/tracing/results2_template.html (right):

https://codereview.chromium.org/2474573002/diff/280001/tracing/tracing/result...
tracing/tracing/results2_template.html:118: importer = undefined;
?

https://codereview.chromium.org/2474573002/diff/280001/tracing/tracing/result...
File tracing/tracing/results_renderer.py (right):

https://codereview.chromium.org/2474573002/diff/280001/tracing/tracing/result...
tracing/tracing/results_renderer.py:16: CHART_JSON_TAG =
'<chart-json>%s</chart-json>'
let's not have this and instead have telemetry precompute the conversion using
vinn.

https://codereview.chromium.org/2474573002/diff/280001/tracing/tracing/value/...
File tracing/tracing/value/chart_json_converter.html (right):

https://codereview.chromium.org/2474573002/diff/280001/tracing/tracing/value/...
tracing/tracing/value/chart_json_converter.html:14: LEGACY_UNIT_INFO.set('%',
{name: 'normalizedPercentage'});
can you move this out into its own module?

the utility is being able to use this to fix a bug that jessi is going to be
working on.

https://codereview.chromium.org/2474573002/diff/280001/tracing/tracing/value/...
File tracing/tracing/value/convert_chart_json.py (right):

https://codereview.chromium.org/2474573002/diff/280001/tracing/tracing/value/...
tracing/tracing/value/convert_chart_json.py:1: #!/usr/bin/env python
yes.

https://codereview.chromium.org/2474573002/diff/280001/tracing/tracing/value/...
File tracing/tracing/value/histogram_set.html (right):

https://codereview.chromium.org/2474573002/diff/280001/tracing/tracing/value/...
tracing/tracing/value/histogram_set.html:240: h =>
tr.v.d.IterationInfo.getField(h, 'legacyTIRLabel', '')),
nit: your indentation isn't style-guide compliant. either 4-space indent
everything or align with the first arg after the (.

[eakuefner, 2016-11-18 21:37:12]

lgtm % more tests

https://codereview.chromium.org/2474573002/diff/280001/tracing/bin/chartjson2...
File tracing/bin/chartjson2histograms (right):

https://codereview.chromium.org/2474573002/diff/280001/tracing/bin/chartjson2...
tracing/bin/chartjson2histograms:1: #!/usr/bin/env python
no need

https://codereview.chromium.org/2474573002/diff/280001/tracing/tracing/result...
File tracing/tracing/results2_template.html (right):

https://codereview.chromium.org/2474573002/diff/280001/tracing/tracing/result...
tracing/tracing/results2_template.html:118: importer = undefined;
?

https://codereview.chromium.org/2474573002/diff/280001/tracing/tracing/result...
File tracing/tracing/results_renderer.py (right):

https://codereview.chromium.org/2474573002/diff/280001/tracing/tracing/result...
tracing/tracing/results_renderer.py:16: CHART_JSON_TAG =
'<chart-json>%s</chart-json>'
let's not have this and instead have telemetry precompute the conversion using
vinn.

https://codereview.chromium.org/2474573002/diff/280001/tracing/tracing/value/...
File tracing/tracing/value/chart_json_converter.html (right):

https://codereview.chromium.org/2474573002/diff/280001/tracing/tracing/value/...
tracing/tracing/value/chart_json_converter.html:14: LEGACY_UNIT_INFO.set('%',
{name: 'normalizedPercentage'});
can you move this out into its own module?

the utility is being able to use this to fix a bug that jessi is going to be
working on.

https://codereview.chromium.org/2474573002/diff/280001/tracing/tracing/value/...
File tracing/tracing/value/convert_chart_json.py (right):

https://codereview.chromium.org/2474573002/diff/280001/tracing/tracing/value/...
tracing/tracing/value/convert_chart_json.py:1: #!/usr/bin/env python
yes.

https://codereview.chromium.org/2474573002/diff/280001/tracing/tracing/value/...
File tracing/tracing/value/histogram_set.html (right):

https://codereview.chromium.org/2474573002/diff/280001/tracing/tracing/value/...
tracing/tracing/value/histogram_set.html:240: h =>
tr.v.d.IterationInfo.getField(h, 'legacyTIRLabel', '')),
nit: your indentation isn't style-guide compliant. either 4-space indent
everything or align with the first arg after the (.

[benjhayden, 2016-11-21 22:22:04]

Description was changed from

==========
Convert chart-json to Histograms.

Currently, TBMv1 benchmarks and other scripts produce chart-json,
which cannot be displayed by results2.html.

This CL implements convertChartJson(), which converts chart-json to
single-bin Histograms with IterationInfo diagnostics.

HtmlOutputFormatter is now unused. If there are no complaints, then it and its
template can be deleted.

https://screenshot.googleplex.com/omepkp6EUPN.png

Legacy units and what to do about them:
https://docs.google.com/spreadsheets/d/1poCtwvaIsXiPQWKGYkz4iOTk6XErpAJPO6aZM...
==========

to

==========
Convert chart-json to Histograms.

Currently, TBMv1 benchmarks and other scripts produce chart-json,
which cannot be displayed by results2.html.

This CL implements ConvertChartJson(), which converts chart-json to
single-bin Histograms with IterationInfo diagnostics.

HtmlOutputFormatter is now unused. If there are no complaints, then it and its
template can be deleted.

https://screenshot.googleplex.com/omepkp6EUPN.png

Legacy units and what to do about them:
https://docs.google.com/spreadsheets/d/1poCtwvaIsXiPQWKGYkz4iOTk6XErpAJPO6aZM...
==========

[eakuefner, 2016-11-22 18:01:48]

https://codereview.chromium.org/2474573002/diff/280001/tracing/tracing/value/...
File tracing/tracing/value/convert_chart_json.py (right):

https://codereview.chromium.org/2474573002/diff/280001/tracing/tracing/value/...
tracing/tracing/value/convert_chart_json.py:1: #!/usr/bin/env python
On 2016/11/18 at 21:37:11, eakuefner wrote:
> yes.

Whoops, I mean no.

[benjhayden, 2016-11-22 21:06:28]

The CQ bit was checked by benjhayden@chromium.org

[benjhayden, 2016-11-22 21:06:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
eakuefner@chromium.org
Link to the patchset: https://codereview.chromium.org/2474573002/#ps500001
(title: ".")

[commit-bot: I haz the power, 2016-11-22 21:06:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 21:25:36]

CQ is committing da patch.

Bot data: {"patchset_id": 500001, "attempt_start_ts": 1479848788275070,
"parent_rev": "d10b57bde75883f4d2281353f5f1976467ecd542", "commit_rev":
"4b8ce174b7ef489bd850983f3897b5d2bf8cbf33"}

[commit-bot: I haz the power, 2016-11-22 21:25:39]

Description was changed from

==========
Convert chart-json to Histograms.

Currently, TBMv1 benchmarks and other scripts produce chart-json,
which cannot be displayed by results2.html.

This CL implements ConvertChartJson(), which converts chart-json to
single-bin Histograms with IterationInfo diagnostics.

HtmlOutputFormatter is now unused. If there are no complaints, then it and its
template can be deleted.

https://screenshot.googleplex.com/omepkp6EUPN.png

Legacy units and what to do about them:
https://docs.google.com/spreadsheets/d/1poCtwvaIsXiPQWKGYkz4iOTk6XErpAJPO6aZM...
==========

to

==========
Convert chart-json to Histograms.

Currently, TBMv1 benchmarks and other scripts produce chart-json,
which cannot be displayed by results2.html.

This CL implements ConvertChartJson(), which converts chart-json to
single-bin Histograms with IterationInfo diagnostics.

HtmlOutputFormatter is now unused. If there are no complaints, then it and its
template can be deleted.

https://screenshot.googleplex.com/omepkp6EUPN.png

Legacy units and what to do about them:
https://docs.google.com/spreadsheets/d/1poCtwvaIsXiPQWKGYkz4iOTk6XErpAJPO6aZM...

Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2016-11-22 21:25:40]

Committed patchset #21 (id:500001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

[alex clarke (OOO till 29th), 2016-11-25 13:50:08]

alexclarke@chromium.org changed reviewers:
+ alexclarke@chromium.org

[alex clarke (OOO till 29th), 2016-11-25 13:50:09]

Please revert this patch.  It completely breaks the following workflow:

git checkout patch
cr build chrome
tools/perf/run_benchmark run --browser=release thread_times.simple_mobile_sites 
 --results-label=patch --also-run-disabled-tests --reset-results

git checkout master
cr build chrome
tools/perf/run_benchmark run --browser=release thread_times.simple_mobile_sites 
 --results-label=master --also-run-disabled-tests 

I'd expect to see data for the two runs but it's not there.

[Primiano Tucci (use gerrit), 2016-11-25 14:20:14]

A revert of this CL (patchset #21 id:500001) has been created in
https://codereview.chromium.org/2528113003/ by primiano@chromium.org.

The reason for reverting is: As per go/catabug/3036 and comment #37 here this
seems to
not work well with run_benchmark and is breaking people's ability
to run A/B tests.

BUG=catapult:3036.