Issue 25314003: SVGPropertyTearOffs should detachChildren before deleting its value

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 25314003: SVGPropertyTearOffs should detachChildren before deleting its value (Closed)

Created:
7 years, 2 months ago by kouhei (in TOK)

Modified:
7 years, 2 months ago

Reviewers:
pdr., ojan, inferno

CC:
blink-reviews, shans, adamk+blink_chromium.org, pdr, Steve Block, dino_apple.com, do-not-use, Nils Barth (inactive), Nate Chapin, alancutter (OOO until 2018), marja+watch_chromium.org, abarth-chromium, dstockwell, Timothy Loh, Eric Willigers, rjwright, darktears, haraken, kojih, jsbell+bindings_chromium.org, Mike Lawther (Google), f(malita), Stephen Chennney

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

SVGPropertyTearOffs should detachChildren before deleting its value. TEST=svg/transforms/svg-matrix-tearoff-crash.html BUG=296276 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158563

Patch Set 1 #

Patch Set 2 : no revert revert revert #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	Source/core/svg/properties/SVGPropertyTearOff.h	View	1	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

pdr.

On 2013/09/30 17:55:57, kouhei wrote: > pdr, ojan: Would you take a look? Thanks! LGTM ...

7 years, 2 months ago (2013-09-30 17:58:36 UTC) #2

kouhei (in TOK)

On 2013/09/30 17:58:36, pdr wrote: > On 2013/09/30 17:55:57, kouhei wrote: > > pdr, ojan: ...

7 years, 2 months ago (2013-09-30 19:24:22 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/25314003/3001

7 years, 2 months ago (2013-09-30 19:25:28 UTC) #4

Message was sent while issue was closed.

Change committed as 158563

Expand Messages | Collapse Messages