Source/core/svg/properties/SVGPropertyTearOff.h - Issue 25314003: SVGPropertyTearOffs should detachChildren before deleting its value

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/properties/SVGPropertyTearOff.h

Issue 25314003: SVGPropertyTearOffs should detachChildren before deleting its value (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: no revert revert revert Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/svg/properties/SVGPropertyTearOff.h

diff --git a/Source/core/svg/properties/SVGPropertyTearOff.h b/Source/core/svg/properties/SVGPropertyTearOff.h

index 0d3b45ce7b1e8a5863739e46441cd5cc21894a81..a78bdea5677ea5699aad232121805d653ed56f3a 100644

--- a/Source/core/svg/properties/SVGPropertyTearOff.h

+++ b/Source/core/svg/properties/SVGPropertyTearOff.h

@@ -56,8 +56,10 @@ public:

void setValue(PropertyType& value)

{

- if (m_valueIsCopy)

+ if (m_valueIsCopy) {

+ detachChildren();

delete m_value;

+ }

m_valueIsCopy = false;

m_value = &value;

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »