net: Cleanup class/struct forward declarations

net: Cleanup class/struct forward declarations

Remove useless class and struct forward declarations, and add
missing ones in net header files.

BUG=662195
Committed: https://crrev.com/65594e01ad47610c8635966bbb86e80dbb82252c
Cr-Commit-Position: refs/heads/master@{#435053}

[jbriance, 2016-11-28 17:21:58]

jbriance@cisco.com changed reviewers:
+ gavinp@chromium.org

[Ryan Sleevi, 2016-11-28 17:50:03]

rsleevi@chromium.org changed reviewers:
+ rsleevi@chromium.org

[Ryan Sleevi, 2016-11-28 17:50:04]

Suggestion: You may want to pick a different //net owner based on activity in
//net

[jbriance, 2016-11-28 20:33:01]

On 2016/11/28 17:50:04, Ryan Sleevi wrote:
> Suggestion: You may want to pick a different //net owner based on activity in
> //net

Thanks for the hint, I just picked git cl presubmit suggestion :)

[jbriance, 2016-11-28 20:33:50]

Description was changed from

==========
net: Cleanup class/struct forward declarations

Remove useless class and struct forward declarations, and add
missing ones in net header files.

BUG=662195
==========

to

==========
net: Cleanup class/struct forward declarations

Remove useless class and struct forward declarations, and add
missing ones in net header files.

BUG=662195
==========

[jbriance, 2016-11-28 20:33:51]

jbriance@cisco.com changed reviewers:
+ mmenke@chromium.org

[Ryan Sleevi, 2016-11-28 23:17:12]

rsleevi@chromium.org changed reviewers:
+ rch@chromium.org
- mmenke@chromium.org

[Ryan Sleevi, 2016-11-28 23:17:13]

LG w/ one nit. I think you'll want to split off the quic/core into a separate CL
and rch@ may need to land/coordinate that - cc'ing him.

https://codereview.chromium.org/2531373002/diff/1/net/cert/x509_certificate.h
File net/cert/x509_certificate.h (right):

https://codereview.chromium.org/2531373002/diff/1/net/cert/x509_certificate.h...
net/cert/x509_certificate.h:45: class X509Certificate;
Let's not do this. The typedef (line 47) should be moved after the class
definition

[Ryan Hamilton, 2016-11-28 23:58:33]

On 2016/11/28 23:17:13, Ryan Sleevi wrote:
> LG w/ one nit. I think you'll want to split off the quic/core into a separate
CL
> and rch@ may need to land/coordinate that - cc'ing him.

Thanks for looping me in. This looks pretty simple, so I'll go ahead and merge
it to the internal repo. Thanks for doing this. You're good to go on the QUIC
code.

Did you use a tool to generate this CL? If so, how can I run it :)

[jbriance, 2016-11-29 08:40:42]

On 2016/11/28 23:58:33, Ryan Hamilton wrote:
> Did you use a tool to generate this CL? If so, how can I run it :)

Tool is a big word for that, but I use a small quick & dirty script, attached in
the 4th comment of bug 662195
(https://bugs.chromium.org/p/chromium/issues/detail?id=662195#c4)
Please also note that there is now a presubmit check to avoid new useless
forward declarations in the codebase.
(https://codereview.chromium.org/2532583002)

https://codereview.chromium.org/2531373002/diff/1/net/cert/x509_certificate.h
File net/cert/x509_certificate.h (right):

https://codereview.chromium.org/2531373002/diff/1/net/cert/x509_certificate.h...
net/cert/x509_certificate.h:45: class X509Certificate;
On 2016/11/28 23:17:13, Ryan Sleevi wrote:
> Let's not do this. The typedef (line 47) should be moved after the class
> definition

I can't : X509Certificate class is used to typedef CertificateList below, and
CertificateList is used in X509Certificate class declaration itself.

[Ryan Sleevi, 2016-11-29 16:57:29]

Ah, circular definitions! Gross :)

LGTM :)

[Ryan Sleevi, 2016-11-29 16:57:38]

The CQ bit was checked by rsleevi@chromium.org

[commit-bot: I haz the power, 2016-11-29 16:57:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 17:02:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 17:02:20]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[jbriance, 2016-11-29 17:09:32]

The CQ bit was checked by jbriance@cisco.com

[jbriance, 2016-11-29 17:09:33]

The patchset sent to the CQ was uploaded after l-g-t-m from rsleevi@chromium.org
Link to the patchset: https://codereview.chromium.org/2531373002/#ps20001
(title: "Rebase on top of master branch")

[commit-bot: I haz the power, 2016-11-29 17:09:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 19:36:39]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480439372904040,
"parent_rev": "287e97fdfc3a7b32cb386850428de1c64eaf7c3d", "commit_rev":
"8d570d99c2c72ac961db2749c7976d77c9240b90"}

[commit-bot: I haz the power, 2016-11-29 19:38:27]

Description was changed from

==========
net: Cleanup class/struct forward declarations

Remove useless class and struct forward declarations, and add
missing ones in net header files.

BUG=662195
==========

to

==========
net: Cleanup class/struct forward declarations

Remove useless class and struct forward declarations, and add
missing ones in net header files.

BUG=662195
==========

[commit-bot: I haz the power, 2016-11-29 19:38:29]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-29 19:41:18]

Description was changed from

==========
net: Cleanup class/struct forward declarations

Remove useless class and struct forward declarations, and add
missing ones in net header files.

BUG=662195
==========

to

==========
net: Cleanup class/struct forward declarations

Remove useless class and struct forward declarations, and add
missing ones in net header files.

BUG=662195

Committed: https://crrev.com/65594e01ad47610c8635966bbb86e80dbb82252c
Cr-Commit-Position: refs/heads/master@{#435053}
==========

[commit-bot: I haz the power, 2016-11-29 19:41:20]

Patchset 2 (id:??) landed as
https://crrev.com/65594e01ad47610c8635966bbb86e80dbb82252c
Cr-Commit-Position: refs/heads/master@{#435053}