net: Cleanup class/struct forward declarations

net/cert/x509_certificate.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_CERT_X509_CERTIFICATE_H_
 #define NET_CERT_X509_CERTIFICATE_H_
 
 #include <stddef.h>
 #include <string.h>
 
@@ skipping 24 matching lines @@
 struct CERTCertificateStr;
 #endif
 
 namespace base {
 class Pickle;
 class PickleIterator;
 }
 
 namespace net {
 
-class CRLSet;
-class CertVerifyResult;
+class X509Certificate;

[Ryan Sleevi, 2016/11/28 23:17:13]

Let's not do this. The typedef (line 47) should be moved after the class
definition

[jbriance, 2016/11/29 08:40:42]

I can't : X509Certificate class is used to typedef CertificateList below, and
CertificateList is used in X509Certificate class declaration itself.

 
 typedef std::vector<scoped_refptr<X509Certificate> > CertificateList;
 
 // X509Certificate represents a X.509 certificate, which is comprised a
 // particular identity or end-entity certificate, such as an SSL server
 // identity or an SSL client certificate, and zero or more intermediate
 // certificates that may be used to build a path to a root certificate.
 class NET_EXPORT X509Certificate
     : public base::RefCountedThreadSafe<X509Certificate> {
  public:
@@ skipping 412 matching lines @@
   // based on the type of the certificate.
   std::string default_nickname_;
 #endif
 
   DISALLOW_COPY_AND_ASSIGN(X509Certificate);
 };
 
 }  // namespace net
 
 #endif  // NET_CERT_X509_CERTIFICATE_H_