Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Issue 25313003: V8ScriptRunner should accept v8::Value as an receiver (Closed)

Created:
7 years, 2 months ago by yusukesuzuki
Modified:
7 years, 2 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, Nils Barth (inactive), kojih, jsbell+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, haraken, Nate Chapin, do-not-use
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

V8ScriptRunner should accept v8::Value as an receiver Since the primitive value can be used as an receiver of a function call from ECMA262 5th, V8ScriptRunner should accept v8::Value as an receiver. This change should be landed after the V8-side CL[1] is landed and V8 is rolled. [1]: https://chromiumcodereview.appspot.com/24920003/ BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158583

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M Source/bindings/v8/V8ScriptRunner.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/bindings/v8/V8ScriptRunner.cpp View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
yusukesuzuki
The V8-side CL[1] is already landed. But currently V8 is not rolled. So this patch ...
7 years, 2 months ago (2013-09-30 19:34:23 UTC) #1
abarth-chromium
Crazy. LGTM
7 years, 2 months ago (2013-09-30 20:10:46 UTC) #2
yusukesuzuki
V8 roll comes :) I'll commit it.
7 years, 2 months ago (2013-09-30 21:04:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukesuzuki@chromium.org/25313003/1
7 years, 2 months ago (2013-09-30 21:05:12 UTC) #4
commit-bot: I haz the power
7 years, 2 months ago (2013-10-01 03:08:29 UTC) #5
Message was sent while issue was closed.
Change committed as 158583

Powered by Google App Engine
This is Rietveld 408576698