Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 2531113002: Devirtualize DictionaryValue::Remove and DictionaryValue::RemovePath (Closed)

Created:
4 years ago by dcheng
Modified:
4 years ago
Reviewers:
gab
CC:
chromium-reviews, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Devirtualize DictionaryValue::Remove and DictionaryValue::RemovePath BUG=none Committed: https://crrev.com/5f9cf76357d412f4b5f5115e3b19842a9ec55754 Cr-Commit-Position: refs/heads/master@{#434902}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M base/values.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
dcheng
4 years ago (2016-11-25 22:47:00 UTC) #2
gab
lgtm
4 years ago (2016-11-28 16:21:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2531113002/1
4 years ago (2016-11-28 17:13:11 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, no build URL)
4 years ago (2016-11-28 22:56:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2531113002/1
4 years ago (2016-11-29 01:34:10 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 05:31:03 UTC) #11
commit-bot: I haz the power
4 years ago (2016-11-29 05:33:30 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5f9cf76357d412f4b5f5115e3b19842a9ec55754
Cr-Commit-Position: refs/heads/master@{#434902}

Powered by Google App Engine
This is Rietveld 408576698