Refactor overlay fullscreen video handling into a single callback

third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

Index: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
index 26c96f482d36418c0f2e33185ac42c97bb136068..98a964c321f39f8c59fbb02c48e4011ee15cf46c 100644
--- a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
@@ -1194,10 +1194,8 @@ void HTMLMediaElement::startPlayerLoad(const KURL& playerProvidedUrl) {
 
   m_webMediaPlayer->load(loadType(), source, corsMode());
 
-  if (isFullscreen()) {
-    // This handles any transition to or from fullscreen overlay mode.
-    frame->chromeClient().enterFullscreenForElement(this);
-  }
+  if (isFullscreen())
+    m_webMediaPlayer->enteredFullscreen();

[foolip, 2016/11/24 21:03:39]

This change isn't strictly necessary in this CL, but it fits here and would
otherwise have to be changed in a coming CL. Destroying the WebMediaPlayer
doesn't exit fullscreen or, AFAICT, mess up any other state, so merely telling
the new WebMediaPlayer about the situation should suffice. Relevant previous
CLs:
https://codereview.chromium.org/1254613003
https://codereview.chromium.org/1689043002

[watk, 2016/11/29 21:11:00]

I don't remember the details but I think this is fine. This was needed
previously because we might stay in fullscreen but change which WebMediaPlayer
is fullscreened, which means usesOverlayFullscreenVideo() could change while in
fullscreen. But I assume with this change we will call
fullscreenElementChanged() in this case?

[foolip, 2016/11/29 21:52:28]

Just the m_inOverlayFullscreenVideo should be enough to make sure that the
transparency is restored. Maybe what happened here is that first
frame->chromeClient().enterFullscreenForElement(this) was added and found to fix
part of the problem, then m_inOverlayFullscreenVideo was added, but
enterFullscreenForElement was left because it works. I'm pretty sure that
m_webMediaPlayer->enteredFullscreen() will now suffice, fingers crossed.

 }
 
 void HTMLMediaElement::setPlayerPreload() {
@@ -3500,7 +3498,7 @@ void HTMLMediaElement::exitFullscreen() {
   Fullscreen::exitFullscreen(document());
 }
 
-void HTMLMediaElement::didBecomeFullscreenElement() {
+void HTMLMediaElement::didEnterFullscreen() {
   if (mediaControls())
     mediaControls()->enteredFullscreen();
   // FIXME: There is no embedder-side handling in layout test mode.
@@ -3513,7 +3511,7 @@ void HTMLMediaElement::didBecomeFullscreenElement() {
         CompositingUpdateRebuildTree);
 }
 
-void HTMLMediaElement::willStopBeingFullscreenElement() {
+void HTMLMediaElement::didExitFullscreen() {
   if (mediaControls())
     mediaControls()->exitedFullscreen();
   if (webMediaPlayer())