Add WebMediaPlayer::exitedFullscreen() and call it from HTMLMediaElement

Add WebMediaPlayer::exitedFullscreen() and call it from HTMLMediaElement

Previously WebMediaPlayers were only notified when entering fullscreen and
only if they returned true from supportsOverlayFullscreenVideo(). Now there
will always be a call when entering fullscreen, and there's a matching
exitedFullscreen() call. WebMediaPlayerImpl will use these on Android to
switch the video decoder output surface.

This also renames enterFullscreen to enteredFullscreen.

This CL to start using this is https://codereview.chromium.org/1655083002/

BUG=533630
Committed: https://crrev.com/a4c3d4f6fc6909aa1effc8c83dee65bd2cccac08
Cr-Commit-Position: refs/heads/master@{#376029}

[watk, 2016-02-11 02:09:18]

watk@chromium.org changed reviewers:
+ bokan@chromium.org, philipj@opera.com, qinmin@chromium.org

[watk, 2016-02-11 02:09:18]

bokan@chromium.org: Please review changes in FullscreenController.cpp

philipj@opera.com: Please review changes in HTMLME and WebMediaPlayer.h

qinmin@chromium.org: Please review changes in content/

[bokan, 2016-02-11 17:59:07]

lgtm

[watk, 2016-02-11 22:45:01]

Description was changed from

==========
Add WebMediaPlayer::exitedFullscreen() and call it from HTMLMediaElement

Previously WebMediaPlayers were only notified when entering fullscreen and
only if they returned true from supportsOverlayFullscreenVideo(). Now there
will always be a call when entering fullscreen, and there's a matching
exitedFullscreen() call. WebMediaPlayerImpl will use these on Android to
switch the video decoder output surface.

This also renames enterFullscreen to enteredFullscreen.

BUG=533630
==========

to

==========
Add WebMediaPlayer::exitedFullscreen() and call it from HTMLMediaElement

Previously WebMediaPlayers were only notified when entering fullscreen and
only if they returned true from supportsOverlayFullscreenVideo(). Now there
will always be a call when entering fullscreen, and there's a matching
exitedFullscreen() call. WebMediaPlayerImpl will use these on Android to
switch the video decoder output surface.

This also renames enterFullscreen to enteredFullscreen.

BUG=533630
==========

[watk, 2016-02-11 22:45:01]

watk@chromium.org changed reviewers:
- philipj@opera.com

[watk, 2016-02-11 22:53:24]

watk@chromium.org changed reviewers:
+ fs@opera.com, jochen@chromium.org

[watk, 2016-02-11 22:53:24]

-philipj because he's OOO.

fs@opera.com: Please review changes in HTMLME

jochen@chromium.org: Please review changes in WebMediaPlayer.h

[watk, 2016-02-11 22:53:36]

The CQ bit was checked by watk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-11 22:54:33]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1689043002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1689043002/1

[commit-bot: I haz the power, 2016-02-12 00:20:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-12 00:20:44]

Dry run: This issue passed the CQ dry run.

[fs, 2016-02-12 09:43:31]

HTMLMediaElement changes LGTM.

I'll take the opportunity to note that 'did'/'will' prefixes may have been more
"idiomatic" - especially considering one of the methods is a 'will', while the
other is a 'did' (which means 'exited' is slightly misleading). I can see (one
place) where you got this from though =). Renaming the calls on MediaControls
would probably make sense too framed like that (but needn't necessarily be done
by you/this CL.)

[fs, 2016-02-12 09:51:39]

On 2016/02/12 at 09:43:31, fs wrote:
> HTMLMediaElement changes LGTM.
> 
> I'll take the opportunity to note that 'did'/'will' prefixes may have been
more "idiomatic" - especially considering one of the methods is a 'will', while
the other is a 'did' (which means 'exited' is slightly misleading). I can see
(one place) where you got this from though =). Renaming the calls on
MediaControls would probably make sense too framed like that (but needn't
necessarily be done by you/this CL.)

Might be nice to mention the "enabler" CL too (I guess that's
https://codereview.chromium.org/1655083002/ ?)

[watk, 2016-02-12 19:01:37]

Description was changed from

==========
Add WebMediaPlayer::exitedFullscreen() and call it from HTMLMediaElement

Previously WebMediaPlayers were only notified when entering fullscreen and
only if they returned true from supportsOverlayFullscreenVideo(). Now there
will always be a call when entering fullscreen, and there's a matching
exitedFullscreen() call. WebMediaPlayerImpl will use these on Android to
switch the video decoder output surface.

This also renames enterFullscreen to enteredFullscreen.

BUG=533630
==========

to

==========
Add WebMediaPlayer::exitedFullscreen() and call it from HTMLMediaElement

Previously WebMediaPlayers were only notified when entering fullscreen and
only if they returned true from supportsOverlayFullscreenVideo(). Now there
will always be a call when entering fullscreen, and there's a matching
exitedFullscreen() call. WebMediaPlayerImpl will use these on Android to
switch the video decoder output surface.

This also renames enterFullscreen to enteredFullscreen.

This CL to start using this is https://codereview.chromium.org/1655083002/

BUG=533630
==========

[watk, 2016-02-12 19:01:37]

watk@chromium.org changed reviewers:
- jochen@chromium.org

[watk, 2016-02-12 19:08:45]

On 2016/02/12 09:51:39, fs wrote:
> On 2016/02/12 at 09:43:31, fs wrote:
> > HTMLMediaElement changes LGTM.
> > 
> > I'll take the opportunity to note that 'did'/'will' prefixes may have been
> more "idiomatic" - especially considering one of the methods is a 'will',
while
> the other is a 'did' (which means 'exited' is slightly misleading). I can see
> (one place) where you got this from though =). Renaming the calls on
> MediaControls would probably make sense too framed like that (but needn't
> necessarily be done by you/this CL.)

Good to know. I went for consistency with MediaControls. And the only call to
willStopBeingFullscreenElement is from didExitFullScreenForElement.. so I'm
confused about whether it's a 'did' or a 'will'.

> Might be nice to mention the "enabler" CL too (I guess that's
> https://codereview.chromium.org/1655083002/ ?)

Sure, added.

[watk, 2016-02-12 19:09:08]

watk@chromium.org changed reviewers:
+ dstockwell@chromium.org

[watk, 2016-02-12 19:09:09]

dstockwell@chromium.org: Please review changes in WebMediaPlayer.h

[dstockwell, 2016-02-15 23:41:36]

lgtm

[philipj_slow, 2016-02-16 10:03:08]

philipj@opera.com changed reviewers:
+ philipj@opera.com

[philipj_slow, 2016-02-16 10:03:08]

lgtm

m

[philipj_slow, 2016-02-16 10:04:24]

On 2016/02/16 10:03:08, philipj_UTC7 wrote:
> lgtm
> 
> m

Read as: "Looks good to me... miaow?"

[watk, 2016-02-16 20:08:24]

On 2016/02/16 10:04:24, philipj_UTC7 wrote:
> On 2016/02/16 10:03:08, philipj_UTC7 wrote:
> > lgtm
> > 
> > m
> 
> Read as: "Looks good to me... miaow?"

Haha, has your cat been doing your code reviews all along, philipj?

Friendly ping qinmin@

[philipj_slow, 2016-02-17 02:50:45]

On 2016/02/16 20:08:24, watk wrote:
> On 2016/02/16 10:04:24, philipj_UTC7 wrote:
> > On 2016/02/16 10:03:08, philipj_UTC7 wrote:
> > > lgtm
> > > 
> > > m
> > 
> > Read as: "Looks good to me... miaow?"
> 
> Haha, has your cat been doing your code reviews all along, philipj?

Busted :)

[watk, 2016-02-17 22:07:24]

On 2016/02/17 02:50:45, philipj_UTC7 wrote:
> On 2016/02/16 20:08:24, watk wrote:
> > On 2016/02/16 10:04:24, philipj_UTC7 wrote:
> > > On 2016/02/16 10:03:08, philipj_UTC7 wrote:
> > > > lgtm
> > > > 
> > > > m
> > > 
> > > Read as: "Looks good to me... miaow?"
> > 
> > Haha, has your cat been doing your code reviews all along, philipj?
> 
> Busted :)

ping qinmin@

[qinmin, 2016-02-17 22:12:14]

lgtm

[watk, 2016-02-17 22:12:58]

The CQ bit was checked by watk@chromium.org

[commit-bot: I haz the power, 2016-02-17 22:13:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1689043002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1689043002/1

[commit-bot: I haz the power, 2016-02-17 23:30:29]

Description was changed from

==========
Add WebMediaPlayer::exitedFullscreen() and call it from HTMLMediaElement

Previously WebMediaPlayers were only notified when entering fullscreen and
only if they returned true from supportsOverlayFullscreenVideo(). Now there
will always be a call when entering fullscreen, and there's a matching
exitedFullscreen() call. WebMediaPlayerImpl will use these on Android to
switch the video decoder output surface.

This also renames enterFullscreen to enteredFullscreen.

This CL to start using this is https://codereview.chromium.org/1655083002/

BUG=533630
==========

to

==========
Add WebMediaPlayer::exitedFullscreen() and call it from HTMLMediaElement

Previously WebMediaPlayers were only notified when entering fullscreen and
only if they returned true from supportsOverlayFullscreenVideo(). Now there
will always be a call when entering fullscreen, and there's a matching
exitedFullscreen() call. WebMediaPlayerImpl will use these on Android to
switch the video decoder output surface.

This also renames enterFullscreen to enteredFullscreen.

This CL to start using this is https://codereview.chromium.org/1655083002/

BUG=533630
==========

[commit-bot: I haz the power, 2016-02-17 23:30:30]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-17 23:31:50]

Description was changed from

==========
Add WebMediaPlayer::exitedFullscreen() and call it from HTMLMediaElement

Previously WebMediaPlayers were only notified when entering fullscreen and
only if they returned true from supportsOverlayFullscreenVideo(). Now there
will always be a call when entering fullscreen, and there's a matching
exitedFullscreen() call. WebMediaPlayerImpl will use these on Android to
switch the video decoder output surface.

This also renames enterFullscreen to enteredFullscreen.

This CL to start using this is https://codereview.chromium.org/1655083002/

BUG=533630
==========

to

==========
Add WebMediaPlayer::exitedFullscreen() and call it from HTMLMediaElement

Previously WebMediaPlayers were only notified when entering fullscreen and
only if they returned true from supportsOverlayFullscreenVideo(). Now there
will always be a call when entering fullscreen, and there's a matching
exitedFullscreen() call. WebMediaPlayerImpl will use these on Android to
switch the video decoder output surface.

This also renames enterFullscreen to enteredFullscreen.

This CL to start using this is https://codereview.chromium.org/1655083002/

BUG=533630

Committed: https://crrev.com/a4c3d4f6fc6909aa1effc8c83dee65bd2cccac08
Cr-Commit-Position: refs/heads/master@{#376029}
==========

[commit-bot: I haz the power, 2016-02-17 23:31:51]

Patchset 1 (id:??) landed as
https://crrev.com/a4c3d4f6fc6909aa1effc8c83dee65bd2cccac08
Cr-Commit-Position: refs/heads/master@{#376029}