Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 253083002: Fix scale on axis may be negative. (Closed)

Created:
6 years, 7 months ago by Yupei Wang
Modified:
6 years, 7 months ago
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix scale on axis may be negative. This patch modifies judgment condition whether is equal to zero for double type, avoid unnecessary sqrt calls in more case. If "a" and "b" are both equal to zero, and "c" is less then zero, currently ScaleOnAxis will return "c" which is negative. So, we should ensure that the result is greater than zero. BUG=none. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267078

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -6 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M cc/base/math_util.cc View 1 chunk +10 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Yupei Wang
Hi Aelias, I'm very sorry, yesterday I sent a codereview using an invalid account. Now ...
6 years, 7 months ago (2014-04-29 02:13:09 UTC) #1
Yupei Wang
On 2014/04/29 02:13:09, Yupei Wang wrote: > Hi Aelias, I'm very sorry, yesterday I sent ...
6 years, 7 months ago (2014-04-29 03:02:33 UTC) #2
aelias_OOO_until_Jul13
lgtm
6 years, 7 months ago (2014-04-29 03:03:11 UTC) #3
Yupei Wang
The CQ bit was checked by perryuwang@tencent.com
6 years, 7 months ago (2014-04-29 03:22:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/perryuwang@tencent.com/253083002/1
6 years, 7 months ago (2014-04-29 03:23:23 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 04:00:40 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit
6 years, 7 months ago (2014-04-29 04:00:40 UTC) #7
Yupei Wang
6 years, 7 months ago (2014-04-29 09:37:05 UTC) #8
James Wei
The CQ bit was checked by wistoch@chromium.org
6 years, 7 months ago (2014-04-30 05:00:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/perryuwang@tencent.com/253083002/1
6 years, 7 months ago (2014-04-30 05:02:10 UTC) #10
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 05:09:13 UTC) #11
Message was sent while issue was closed.
Change committed as 267078

Powered by Google App Engine
This is Rietveld 408576698