Issue 47403002: Avoid unnecessary sqrt calls in ComputeTransform2dScaleComponents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 47403002: Avoid unnecessary sqrt calls in ComputeTransform2dScaleComponents. (Closed)

Created:
7 years, 1 month ago by aelias_OOO_until_Jul13

Modified:
7 years, 1 month ago

Reviewers:
enne (OOO)

CC:
chromium-reviews, cc-bugs_chromium.org, danakj, Tom Hudson

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Avoid unnecessary sqrt calls in ComputeTransform2dScaleComponents. This method performed 2 sqrt calls for every layer during CalcDrawProperties. In most cases, only the main diagonal has nonzero values and the sqrt() call can be optimized out. I measured a 20% win in CalcDrawPropsImplTest.TenTen on Nexus 4. NOTRY=true BUG=311472 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231339

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	cc/base/math_util.cc	View		1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aelias@chromium.org/47403002/1

7 years, 1 month ago (2013-10-28 16:29:42 UTC) #3

Message was sent while issue was closed.

Change committed as 231339

Expand Messages | Collapse Messages