Ensure active document for hasEditableLevel

Ensure active document for hasEditableLevel

This patch makes hasEditableStyle and hasRichlyEditableStyle return false
directly if document is inactive, because nothing in an inactive document
is editable.

The ultimate goal is to ensure that no code path inspects editable styles
in an inactive document, which will be done by subsequent patches.

BUG=667681
Committed: https://crrev.com/9ceffba8b9056e7a125f5a9fd8eb803816315df7
Cr-Commit-Position: refs/heads/master@{#434414}

[Xiaocheng, 2016-11-24 03:55:27]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-24 03:56:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-11-24 04:47:43]

xiaochengh@chromium.org changed reviewers:
+ yoichio@chromium.org, yosin@chromium.org

[Xiaocheng, 2016-11-24 04:47:44]

PTAL.

[yoichio, 2016-11-24 04:54:40]

lgtm

[yosin_UTC9, 2016-11-24 05:05:25]

The CQ bit was unchecked by yosin@chromium.org

[yosin_UTC9, 2016-11-24 05:05:28]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2016-11-24 05:05:28]

lgtm

[commit-bot: I haz the power, 2016-11-24 05:05:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2016-11-24 05:06:22]

Please add description 
 - why you introduce this
 - rationale for returning false for inactive document.

[Xiaocheng, 2016-11-24 05:18:10]

Description was changed from

==========
Ensure active document for hasEditableLevel

BUG=667681
==========

to

==========
Ensure active document for hasEditableLevel

This patch makes hasEditableStyle and hasRichlyEditableStyle return false
directly if document is inactive, because nothing in an inactive document
is editable.

The ultimate goal is to ensure that no code path inspects editable styles
in an inactive document, which will be done by subsequent patches.

BUG=667681
==========

[Xiaocheng, 2016-11-24 05:18:22]

On 2016/11/24 at 05:06:22, yosin wrote:
> Please add description 
>  - why you introduce this
>  - rationale for returning false for inactive document.

Done.

[yosin_UTC9, 2016-11-24 05:34:26]

On 2016/11/24 at 05:18:22, xiaochengh wrote:
> On 2016/11/24 at 05:06:22, yosin wrote:
> > Please add description 
> >  - why you introduce this
> >  - rationale for returning false for inactive document.
> 
> Done.

It seems "editable" is independent from document activity[1][2].

[1] https://html.spec.whatwg.org/multipage/interaction.html#editing-2
[2] https://w3c.github.io/editing/execCommand.html#editable

[yosin_UTC9, 2016-11-24 05:36:05]

On 2016/11/24 at 05:34:26, Yosi_UTC9 wrote:
> On 2016/11/24 at 05:18:22, xiaochengh wrote:
> > On 2016/11/24 at 05:06:22, yosin wrote:
> > > Please add description 
> > >  - why you introduce this
> > >  - rationale for returning false for inactive document.
> > 
> > Done.
> 
> It seems "editable" is independent from document activity[1][2].
> 
> [1] https://html.spec.whatwg.org/multipage/interaction.html#editing-2
> [2] https://w3c.github.io/editing/execCommand.html#editable

Current Blink doesn't allow to set selection in display:none, but others can.
Blink will follow others and execCommand() should work such case.

[commit-bot: I haz the power, 2016-11-24 05:56:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-24 05:56:48]

Try jobs failed on following builders:
  blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[Xiaocheng, 2016-11-24 11:13:06]

The CQ bit was checked by xiaochengh@chromium.org

[commit-bot: I haz the power, 2016-11-24 11:13:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-24 13:14:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-24 13:14:16]

Try jobs failed on following builders:
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[Xiaocheng, 2016-11-24 15:59:36]

The CQ bit was checked by xiaochengh@chromium.org

[commit-bot: I haz the power, 2016-11-24 16:00:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-24 17:16:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-24 17:16:57]

Try jobs failed on following builders:
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Xiaocheng, 2016-11-25 00:32:41]

The CQ bit was checked by xiaochengh@chromium.org

[commit-bot: I haz the power, 2016-11-25 00:32:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-25 00:50:15]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1480033961807530, "parent_rev":
"6c0e36568d9b90100a25f5f5787fbb38d16a0e22", "commit_rev":
"fd5326d70511d40c869cd6c316ef8dbab6ceef3a"}

[commit-bot: I haz the power, 2016-11-25 00:50:40]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-25 00:53:09]

Description was changed from

==========
Ensure active document for hasEditableLevel

This patch makes hasEditableStyle and hasRichlyEditableStyle return false
directly if document is inactive, because nothing in an inactive document
is editable.

The ultimate goal is to ensure that no code path inspects editable styles
in an inactive document, which will be done by subsequent patches.

BUG=667681
==========

to

==========
Ensure active document for hasEditableLevel

This patch makes hasEditableStyle and hasRichlyEditableStyle return false
directly if document is inactive, because nothing in an inactive document
is editable.

The ultimate goal is to ensure that no code path inspects editable styles
in an inactive document, which will be done by subsequent patches.

BUG=667681

Committed: https://crrev.com/9ceffba8b9056e7a125f5a9fd8eb803816315df7
Cr-Commit-Position: refs/heads/master@{#434414}
==========

[commit-bot: I haz the power, 2016-11-25 00:53:10]

Patchset 1 (id:??) landed as
https://crrev.com/9ceffba8b9056e7a125f5a9fd8eb803816315df7
Cr-Commit-Position: refs/heads/master@{#434414}