Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Issue 2526133003: [CANCELED] Ensure clean style for hasEditableLevel when it doesn't break other stuff (Closed)

Created:
4 years ago by Xiaocheng
Modified:
3 years, 10 months ago
Reviewers:
yoichio, yosin_UTC9
CC:
aboxhall+watch_chromium.org, aboxhall, blink-reviews, chromium-reviews, dmazzoni+watch_chromium.org, dmazzoni, dtseng+watch_chromium.org, haraken, je_julie, nektar+watch_chromium.org, nektarios, yuzo+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[CANCELED] Ensure clean style for hasEditableLevel when it doesn't break other stuff Reason for calcel: this patch conflicts with our workload division plan After identifying all the blockers for having clean style in hasEditableLevel, this patch ensures that all other code paths entering the function already have up-to-date style, by adding style update in hasRichlyEditableStyle, and conditionally in hasEditableStyle. Design doc: https://docs.google.com/document/d/1BHqhZQnCDBexNYzg_GethMmm4NqZKVj_eLpNZMPXMzg/edit?usp=sharing BUG=667575

Patch Set 1 #

Patch Set 2 : Thu Nov 24 22:54:36 JST 2016 #

Patch Set 3 : Fri Nov 25 13:23:38 JST 2016 #

Patch Set 4 : Fri Nov 25 14:48:44 JST 2016 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -16 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/tabindex-defaults-expected.txt View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/EditingUtilities.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/EditingUtilities.cpp View 1 2 3 5 chunks +56 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp View 1 2 1 chunk +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXTable.cpp View 1 2 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 23 (20 generated)
Xiaocheng
PTAL. This patch can be the starting point.
4 years ago (2016-11-25 06:32:57 UTC) #16
yoichio
I recommend you using "[]" like "[WIP] first implementation", "[CANCELED] blah blah blah" to mean ...
4 years ago (2016-11-25 08:01:54 UTC) #20
Xiaocheng
4 years ago (2016-11-25 08:08:59 UTC) #22
On 2016/11/25 at 08:01:54, yoichio wrote:
> I recommend you using "[]" like "[WIP] first implementation", "[CANCELED] blah
blah blah"
>  to mean meta tags.

Thanks.

Powered by Google App Engine
This is Rietveld 408576698