Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 2530563002: Remove the enable/disable links for the about:plugins page. (Closed)

Created:
4 years ago by pastarmovj
Modified:
4 years ago
CC:
Aaron Boodman, abarth-chromium, arv+watch_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the enable/disable links for the about:plugins page. They are noops since https://codereview.chromium.org/2518493002/. BUG=615738 TEST=manual CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/b8e1ac73c904f3134c4be5fd978ef46de1b95279 Cr-Commit-Position: refs/heads/master@{#434376}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -101 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/resources/plugins.css View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/resources/plugins.html View 2 chunks +0 lines, -32 lines 0 comments Download
M chrome/browser/resources/plugins.js View 2 chunks +0 lines, -42 lines 0 comments Download
M chrome/browser/ui/webui/plugins/plugins.mojom View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/plugins/plugins_handler.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/plugins/plugins_handler.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/browser/ui/webui/plugins/plugins_ui.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
pastarmovj
Hi Bernhard, this is another pure delete CL. It removes the enable/disable links from the ...
4 years ago (2016-11-23 15:22:35 UTC) #3
Bernhard Bauer
lgtm
4 years ago (2016-11-23 15:38:47 UTC) #4
pastarmovj
Adding Mike for mojom approval.
4 years ago (2016-11-24 08:15:19 UTC) #6
Mike West
lgtm
4 years ago (2016-11-24 13:00:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2530563002/1
4 years ago (2016-11-24 16:50:52 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/279401)
4 years ago (2016-11-24 17:20:15 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2530563002/1
4 years ago (2016-11-24 17:22:30 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/321791)
4 years ago (2016-11-24 17:38:04 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2530563002/1
4 years ago (2016-11-24 18:30:47 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-24 19:04:23 UTC) #19
commit-bot: I haz the power
4 years ago (2016-11-24 19:07:46 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b8e1ac73c904f3134c4be5fd978ef46de1b95279
Cr-Commit-Position: refs/heads/master@{#434376}

Powered by Google App Engine
This is Rietveld 408576698