Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2530543002: Fix the pubspec and warnings in pkg/kernel. (Closed)

Created:
4 years ago by asgerf
Modified:
4 years ago
CC:
dart-kernel+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -127 lines) Patch
M pkg/kernel/lib/analyzer/ast_from_analyzer.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/kernel/lib/analyzer/loader.dart View 3 chunks +4 lines, -1 line 0 comments Download
M pkg/kernel/pubspec.yaml View 2 chunks +3 lines, -2 lines 0 comments Download
D pkg/kernel/test/treeshaker_stacktracer.dart View 1 chunk +0 lines, -122 lines 1 comment Download
M pkg/kernel/test/type_hashcode_test_disabled.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/kernel/test/type_substitution_identity_test_disabled.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
asgerf
4 years ago (2016-11-23 13:31:13 UTC) #4
asgerf
https://codereview.chromium.org/2530543002/diff/1/pkg/kernel/test/treeshaker_stacktracer.dart File pkg/kernel/test/treeshaker_stacktracer.dart (left): https://codereview.chromium.org/2530543002/diff/1/pkg/kernel/test/treeshaker_stacktracer.dart#oldcode9 pkg/kernel/test/treeshaker_stacktracer.dart:9: import 'package:ansicolor/ansicolor.dart'; This depends on the ansicolor package which ...
4 years ago (2016-11-23 13:31:56 UTC) #5
Kevin Millikin (Google)
lgtm
4 years ago (2016-11-23 13:34:28 UTC) #6
asgerf
4 years ago (2016-11-23 13:36:29 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
f13881ac08609f982f77cfcfd230a25d94ab840a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698