Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: pkg/kernel/lib/analyzer/loader.dart

Issue 2530543002: Fix the pubspec and warnings in pkg/kernel. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/kernel/lib/analyzer/loader.dart
diff --git a/pkg/kernel/lib/analyzer/loader.dart b/pkg/kernel/lib/analyzer/loader.dart
index 311738bbf903bfa42531ec91a5d3fba85eeaffc0..1591bcf71f4e70afb4d1899d10b8e272ddb880c5 100644
--- a/pkg/kernel/lib/analyzer/loader.dart
+++ b/pkg/kernel/lib/analyzer/loader.dart
@@ -30,6 +30,7 @@ import 'ast_from_analyzer.dart';
class DartOptions {
/// True if user code should be loaded in strong mode.
bool strongMode;
+
/// True if the Dart SDK should be loaded in strong mode.
bool strongModeSdk;
String sdk;
@@ -132,16 +133,19 @@ class DartLoader implements ReferenceLevelLoader {
promoteToBodyLevel(node);
classes.add(node);
}
+
void loadProcedure(Element memberElement) {
var node = getMemberReference(memberElement);
_buildTopLevelMember(node, memberElement);
procedures.add(node);
}
+
void loadField(Element memberElement) {
var node = getMemberReference(memberElement);
_buildTopLevelMember(node, memberElement);
fields.add(node);
}
+
for (var unit in element.units) {
unit.types.forEach(loadClass);
unit.enums.forEach(loadClass);
@@ -730,7 +734,6 @@ Future<Packages> createPackages(String packagePath,
AnalysisOptions createAnalysisOptions(bool strongMode) {
return new AnalysisOptionsImpl()
..strongMode = strongMode
- ..enableGenericMethods = strongMode
..generateImplicitErrors = false
..generateSdkErrors = false
..preserveComments = false

Powered by Google App Engine
This is Rietveld 408576698