chrome/browser/extensions/api/extension_action/browser_action_apitest.cc - Issue 25305002: Implement initial chrome.browserAction.openPopup API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/extension_action/browser_action_apitest.cc

Issue 25305002: Implement initial chrome.browserAction.openPopup API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: move to interactive_ui_test Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/active_tab_apitest.cc ('k') | chrome/browser/extensions/api/extension_action/browser_action_interactive_test.cc » ('j') | chrome/renderer/resources/extensions/browser_action_custom_bindings.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/extension_action/browser_action_apitest.cc

diff --git a/chrome/browser/extensions/api/extension_action/browser_action_apitest.cc b/chrome/browser/extensions/api/extension_action/browser_action_apitest.cc

index 06017801b9eabeeadf4879fe04e0e154f337a984..dc680e30177caf737c931b086c9f9cd9956534a7 100644

--- a/chrome/browser/extensions/api/extension_action/browser_action_apitest.cc

+++ b/chrome/browser/extensions/api/extension_action/browser_action_apitest.cc

@@ -120,7 +120,8 @@ IN_PROC_BROWSER_TEST_F(BrowserActionApiTest, Basic) {

ExtensionService* service = extensions::ExtensionSystem::Get(

browser()->profile())->extension_service();

- service->toolbar_model()->ExecuteBrowserAction(extension, browser(), NULL);

+ service->toolbar_model()->ExecuteBrowserAction(

+ extension, browser(), NULL, true);

ASSERT_TRUE(catcher.GetNextResult()) << catcher.message();

}

@@ -590,7 +591,7 @@ IN_PROC_BROWSER_TEST_F(BrowserActionApiTest, DISABLED_CloseBackgroundPage) {

// Click the browser action.

extensions::ExtensionSystem::Get(browser()->profile())->extension_service()->

- toolbar_model()->ExecuteBrowserAction(extension, browser(), NULL);

+ toolbar_model()->ExecuteBrowserAction(extension, browser(), NULL, true);

// It can take a moment for the background page to actually get destroyed

// so we wait for the notification before checking that it's really gone