Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: chrome/browser/extensions/active_tab_apitest.cc

Issue 25305002: Implement initial chrome.browserAction.openPopup API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: move to interactive_ui_test Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/active_tab_apitest.cc
diff --git a/chrome/browser/extensions/active_tab_apitest.cc b/chrome/browser/extensions/active_tab_apitest.cc
index d6a6d1daa22a32442f17d315dc15dc3f4414627e..1ec7e32c059512d7a95b61ce3a236248419feee4 100644
--- a/chrome/browser/extensions/active_tab_apitest.cc
+++ b/chrome/browser/extensions/active_tab_apitest.cc
@@ -43,7 +43,8 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, MAYBE_ActiveTab) {
// Granting to the extension should give it access to page.html.
{
ResultCatcher catcher;
- service->toolbar_model()->ExecuteBrowserAction(extension, browser(), NULL);
+ service->toolbar_model()->ExecuteBrowserAction(
+ extension, browser(), NULL, true);
EXPECT_TRUE(catcher.GetNextResult()) << message_;
}

Powered by Google App Engine
This is Rietveld 408576698