Implement initial chrome.browserAction.openPopup API.

chrome/browser/ui/views/browser_actions_container.h

Index: chrome/browser/ui/views/browser_actions_container.h
diff --git a/chrome/browser/ui/views/browser_actions_container.h b/chrome/browser/ui/views/browser_actions_container.h
index 9e3fc949c58b67c126b73e3f558ee3d9f8a75b6f..1827126df73e628c52e80589a5845c8d177cbcf5 100644
--- a/chrome/browser/ui/views/browser_actions_container.h
+++ b/chrome/browser/ui/views/browser_actions_container.h
@@ -259,6 +259,8 @@ class BrowserActionsContainer
       const extensions::Extension* extension) OVERRIDE;
   virtual void BrowserActionMoved(const extensions::Extension* extension,
                                   int index) OVERRIDE;
+  virtual bool BrowserActionShowPopup(
+      const extensions::Extension* extension) OVERRIDE;
   virtual void ModelLoaded() OVERRIDE;
 
   void LoadImages();
@@ -309,9 +311,10 @@ class BrowserActionsContainer
   // for incognito.
   bool ShouldDisplayBrowserAction(const extensions::Extension* extension);
 
-  // Show a popup.
-  void ShowPopup(BrowserActionButton* button,
-                 ExtensionPopup::ShowAction show_action);
+  // Show a popup. Returns true if a new popup was shown.
+  bool ShowPopup(BrowserActionButton* button,
+                 ExtensionPopup::ShowAction show_action,
+                 bool should_grant);

[Finnur, 2013/10/18 10:31:01]

Same here -- document should_grant. And while you are at it, maybe document
show_action too.

[justinlin, 2013/10/19 06:01:48]

Old patch set as well. Hmm.. I don't completely understand what show_action does
(SHOW vs SHOW_AND_INSPECT), so I'd rather leave that undocumented..

 
   // The vector of browser actions (icons/image buttons for each action). Note
   // that not every BrowserAction in the ToolbarModel will necessarily be in