Implement initial chrome.browserAction.openPopup API.

chrome/browser/ui/views/browser_actions_container.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_BROWSER_ACTIONS_CONTAINER_H_
 #define CHROME_BROWSER_UI_VIEWS_BROWSER_ACTIONS_CONTAINER_H_
 
 #include "chrome/browser/extensions/extension_keybinding_registry.h"
 #include "chrome/browser/extensions/extension_toolbar_model.h"
 #include "chrome/browser/ui/views/browser_action_view.h"
@@ skipping 241 matching lines @@
   // Returns the height of an icon.
   static int IconHeight();
 
   // ExtensionToolbarModel::Observer implementation.
   virtual void BrowserActionAdded(const extensions::Extension* extension,
                                   int index) OVERRIDE;
   virtual void BrowserActionRemoved(
       const extensions::Extension* extension) OVERRIDE;
   virtual void BrowserActionMoved(const extensions::Extension* extension,
                                   int index) OVERRIDE;
+  virtual bool BrowserActionShowPopup(
+      const extensions::Extension* extension) OVERRIDE;
   virtual void ModelLoaded() OVERRIDE;
 
   void LoadImages();
 
   // Sets the initial container width.
   void SetContainerWidth();
 
   // Closes the overflow menu if open.
   void CloseOverflowMenu();
 
@@ skipping 30 matching lines @@
   // the target size).  This also saves the target number of visible icons in
   // the pref if we're not incognito.
   void SaveDesiredSizeAndAnimate(gfx::Tween::Type type,
                                  size_t num_visible_icons);
 
   // Returns true if this extension should be shown in this toolbar. This can
   // return false if we are in an incognito window and the extension is disabled
   // for incognito.
   bool ShouldDisplayBrowserAction(const extensions::Extension* extension);
 
-  // Show a popup.
-  void ShowPopup(BrowserActionButton* button,
-                 ExtensionPopup::ShowAction show_action);
+  // Show a popup. Returns true if a new popup was shown.
+  bool ShowPopup(BrowserActionButton* button,
+                 ExtensionPopup::ShowAction show_action,
+                 bool should_grant);

[Finnur, 2013/10/18 10:31:01]

Same here -- document should_grant. And while you are at it, maybe document
show_action too.

[justinlin, 2013/10/19 06:01:48]

Old patch set as well. Hmm.. I don't completely understand what show_action does
(SHOW vs SHOW_AND_INSPECT), so I'd rather leave that undocumented..

 
   // The vector of browser actions (icons/image buttons for each action). Note
   // that not every BrowserAction in the ToolbarModel will necessarily be in
   // this collection. Some extensions may be disabled in incognito windows.
   BrowserActionViews browser_action_views_;
 
   Profile* profile_;
 
   // The Browser object the container is associated with.
   Browser* browser_;
@@ skipping 47 matching lines @@
 
   base::WeakPtrFactory<BrowserActionsContainer> task_factory_;
 
   // Handles delayed showing of the overflow menu when hovering.
   base::WeakPtrFactory<BrowserActionsContainer> show_menu_task_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(BrowserActionsContainer);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_BROWSER_ACTIONS_CONTAINER_H_