chrome/common/extensions/api/browser_action.json - Issue 25305002: Implement initial chrome.browserAction.openPopup API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/browser_action.json

Issue 25305002: Implement initial chrome.browserAction.openPopup API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: sync Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/browser_actions_container.cc ('K') | « chrome/common/extensions/api/_api_features.json ('k') | chrome/common/extensions/features/complex_feature.cc » ('j') | chrome/renderer/resources/extensions/browser_action_custom_bindings.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/browser_action.json

diff --git a/chrome/common/extensions/api/browser_action.json b/chrome/common/extensions/api/browser_action.json

index 85dd9bb2db3a3f0f9866e46a819b2e4fe250712a..698cf178fe1e63b7e4590a6109d7db6af0272bfa 100644

--- a/chrome/common/extensions/api/browser_action.json

+++ b/chrome/common/extensions/api/browser_action.json

@@ -310,6 +310,25 @@

"description": "The id of the tab for which you want to modify the browser action."

}

]

+ },

+ {

+ "name": "openPopup",

+ "type": "function",

+ "description": "Opens the extension popup window in the active window but does not grant tab permissions.",

+ "nodoc": true,

+ "parameters": [

+ {

+ "type": "function",

+ "name": "callback",

+ "parameters": [

+ {

+ "name": "popupView",

+ "type": "object",

+ "additionalProperties": { "type": "any" }

+ }

+ ]

+ }

+ ]

}

"events": [