chrome/common/extensions/api/_api_features.json - Issue 25305002: Implement initial chrome.browserAction.openPopup API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/_api_features.json

Issue 25305002: Implement initial chrome.browserAction.openPopup API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: sync Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/browser_actions_container.cc ('K') | « chrome/browser/ui/views/browser_actions_container.cc ('k') | chrome/common/extensions/api/browser_action.json » ('j') | chrome/renderer/resources/extensions/browser_action_custom_bindings.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/_api_features.json

diff --git a/chrome/common/extensions/api/_api_features.json b/chrome/common/extensions/api/_api_features.json

index 8e58146f74dfed3c75f314e0fcfe624ee3f6857f..08de29fab86f2b158d19aadf93e1543052e09dec 100644

--- a/chrome/common/extensions/api/_api_features.json

+++ b/chrome/common/extensions/api/_api_features.json

@@ -104,6 +104,26 @@

"dependencies": ["manifest:browser_action"],

"contexts": ["blessed_extension"]

+ // This API is whitelisted on stable and should not be enabled for a wider

+ // audience without resolving security issues raised in API proposal and

+ // review (https://codereview.chromium.org/25305002).

+ "browserAction.openPopup": [{

+ "channel": "dev",

+ "dependencies": ["manifest:browser_action"],

+ "contexts": ["blessed_extension"]

+ }, {

+ "channel": "stable",

+ "dependencies": ["manifest:browser_action"],

+ "whitelist": [

+ "enhhojjnijigcajfphajepfemndkmdlo", // Dev

+ "pkedcjkdefgpdelpbcmbmeomcjbeemfm", // Trusted Tester

+ "fmfcbgogabcbclcofgocippekhfcmgfj", // Staging

+ "hfaagokkkhdbgiakmmlclaapfelnkoah", // Canary

+ "F155646B5D1CA545F7E1E4E20D573DFDD44C2540", // Trusted Tester (public)

+ "16CA7A47AAE4BE49B1E75A6B960C3875E945B264" // Release

+ ],

+ "contexts": ["blessed_extension"]

+ }],

"browsingData": {

"dependencies": ["permission:browsingData"],

"contexts": ["blessed_extension"]