chrome/browser/chrome_notification_types.h - Issue 25305002: Implement initial chrome.browserAction.openPopup API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chrome_notification_types.h

Issue 25305002: Implement initial chrome.browserAction.openPopup API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/extensions/api/extension_action/extension_action_api.h » ('j') | chrome/browser/extensions/api/extension_action/extension_action_api.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chrome_notification_types.h

diff --git a/chrome/browser/chrome_notification_types.h b/chrome/browser/chrome_notification_types.h

index 9dd9de4102e635ac316426590b9ae62866b853c2..5f025dcdc5c9dd36a96891e93f2c03a7c53533dc 100644

--- a/chrome/browser/chrome_notification_types.h

+++ b/chrome/browser/chrome_notification_types.h

@@ -550,6 +550,8 @@ enum NotificationType {

// associated window.

NOTIFICATION_EXTENSION_COMMAND_BROWSER_ACTION_MAC,

+ NOTIFICATION_EXTENSION_COMMAND_BROWSER_ACTION_SHOW,

mark a. foltz 2013/10/07 22:08:14 What are the source and details for the notificati

justinlin 2013/10/09 18:19:32 no longer needed.

// Sent when an extension command shortcut for a page action is activated

// on Mac. The source is the profile and the details is a std::pair of a

// std::string containing an extension ID and a gfx::NativeWindow for the