chrome/browser/extensions/api/extension_action/extension_action_api.h - Issue 25305002: Implement initial chrome.browserAction.openPopup API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/extension_action/extension_action_api.h

Issue 25305002: Implement initial chrome.browserAction.openPopup API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chrome_notification_types.h ('K') | « chrome/browser/chrome_notification_types.h ('k') | chrome/browser/extensions/api/extension_action/extension_action_api.cc » ('j') | chrome/browser/extensions/api/extension_action/extension_action_api.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/extension_action/extension_action_api.h

diff --git a/chrome/browser/extensions/api/extension_action/extension_action_api.h b/chrome/browser/extensions/api/extension_action/extension_action_api.h

index aa82104168f9fe07daec71b252d582c72ca7e458..d99913c12b2635bc48c486230ac0d8e65772701a 100644

--- a/chrome/browser/extensions/api/extension_action/extension_action_api.h

+++ b/chrome/browser/extensions/api/extension_action/extension_action_api.h

@@ -341,6 +341,17 @@ class BrowserActionDisableFunction : public ExtensionActionHideFunction {

virtual ~BrowserActionDisableFunction() {}

};

+class BrowserActionOpenPopupFunction : public SyncExtensionFunction {

+ public:

+ DECLARE_EXTENSION_FUNCTION("browserAction.openPopup", BROWSERACTION_OPEN_POPUP)

+ protected:

+ virtual ~BrowserActionOpenPopupFunction() {}

+ // ExtensionFunction:

+ virtual bool RunImpl() OVERRIDE;

+};

// scriptBadge.* aliases for supported scriptBadge APIs.