WebKit: make #if DCHECK_IS_ON consistent in third_party/WebKit/Source/platform/

WebKit: make #if DCHECK_IS_ON consistent in third_party/WebKit/Source/platform/

This CL addresses a few problems with #ifdefs:

1) DCHECK requires the presence of variables used in it even if DCHECK_IS_ON()
evaluates to 0. Therefore, if debug variable is defined only when DCHECK_IS_ON()
is true, its usage must be guarded the same way.

2) If debug method in base class is defined only when DCHECK_IS_ON() is true,
its descendants must be guarded with the same check.

BUG=666660
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/bf362660fce245a3bf521fa2caca26b00e2f055a
Cr-Commit-Position: refs/heads/master@{#434149}

[Alexander Alekseev, 2016-11-23 07:33:30]

Description was changed from

==========
WebKit: make #if DCHECK_IS_ON consistent in third_party/WebKit/Source/platform/

This CL addresses a few problems with #ifdefs:

1) DCHECK requires the presence of variables used in it even if DCHECK_IS_ON()
computes to 0. Therefore, if debug variable is defined only when DCHECK_IS_ON()
is true, its usage must be guarded the same way.

2) If debug method in base class is defined only when DCHECK_IS_ON() is true,
its descendants must be guarded with the same check.

BUG=666660
==========

to

==========
WebKit: make #if DCHECK_IS_ON consistent in third_party/WebKit/Source/platform/

This CL addresses a few problems with #ifdefs:

1) DCHECK requires the presence of variables used in it even if DCHECK_IS_ON()
computes to 0. Therefore, if debug variable is defined only when DCHECK_IS_ON()
is true, its usage must be guarded the same way.

2) If debug method in base class is defined only when DCHECK_IS_ON() is true,
its descendants must be guarded with the same check.

BUG=666660
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Alexander Alekseev, 2016-11-23 07:34:20]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 07:34:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alexander Alekseev, 2016-11-23 07:44:23]

Description was changed from

==========
WebKit: make #if DCHECK_IS_ON consistent in third_party/WebKit/Source/platform/

This CL addresses a few problems with #ifdefs:

1) DCHECK requires the presence of variables used in it even if DCHECK_IS_ON()
computes to 0. Therefore, if debug variable is defined only when DCHECK_IS_ON()
is true, its usage must be guarded the same way.

2) If debug method in base class is defined only when DCHECK_IS_ON() is true,
its descendants must be guarded with the same check.

BUG=666660
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
WebKit: make #if DCHECK_IS_ON consistent in third_party/WebKit/Source/platform/

This CL addresses a few problems with #ifdefs:

1) DCHECK requires the presence of variables used in it even if DCHECK_IS_ON()
evaluates to 0. Therefore, if debug variable is defined only when DCHECK_IS_ON()
is true, its usage must be guarded the same way.

2) If debug method in base class is defined only when DCHECK_IS_ON() is true,
its descendants must be guarded with the same check.

BUG=666660
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Alexander Alekseev, 2016-11-23 07:53:06]

alemate@chromium.org changed reviewers:
+ pdr@chromium.org

[Alexander Alekseev, 2016-11-23 07:53:07]

This is third_party/WebKit/Source/platform/ part of
https://codereview.chromium.org/2513893002 (I am splitting it as suggested by
reviewers.)

Please review.

https://codereview.chromium.org/2530493002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/graphics/GraphicsContext.h (right):

https://codereview.chromium.org/2530493002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/GraphicsContext.h:452: int
m_layerCount;
Yuta Kitamura suggested that I should replace DCHECK(m_layerCount-- > 0) with
DCHECK_GT.
But Windows build would fail on "signed/unsigned mismatch".
So I decided that replacement of unsigned with int could be better than force 0
to be unsigned in DCHECK_GT().

https://codereview.chromium.org/2530493002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h (right):

https://codereview.chromium.org/2530493002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h:422: bool
isEndAndPairedWith(DisplayItem::Type otherType) const override = 0;
The only call to this is protected with #if DCHECK_IS_ON() (see
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/platform/graph...
)

https://codereview.chromium.org/2530493002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/heap/PersistentNode.h (right):

https://codereview.chromium.org/2530493002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/heap/PersistentNode.h:134:
DCHECK_GT(m_persistentCount, 0);
This variable exists only if DCHECK_IS_ON() evaluates to true.

[haraken, 2016-11-23 08:17:37]

LGTM

[commit-bot: I haz the power, 2016-11-23 10:41:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 10:41:21]

Dry run: This issue passed the CQ dry run.

[Alexander Alekseev, 2016-11-23 12:14:09]

The CQ bit was checked by alemate@chromium.org

[commit-bot: I haz the power, 2016-11-23 12:14:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 12:18:30]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1479903249632180, "parent_rev":
"efd0fdc66616dad131fcdaf07fa057af5b5987d7", "commit_rev":
"9826dfd5602c2d7c005d8c496ec7c67467265b77"}

[commit-bot: I haz the power, 2016-11-23 12:18:53]

Description was changed from

==========
WebKit: make #if DCHECK_IS_ON consistent in third_party/WebKit/Source/platform/

This CL addresses a few problems with #ifdefs:

1) DCHECK requires the presence of variables used in it even if DCHECK_IS_ON()
evaluates to 0. Therefore, if debug variable is defined only when DCHECK_IS_ON()
is true, its usage must be guarded the same way.

2) If debug method in base class is defined only when DCHECK_IS_ON() is true,
its descendants must be guarded with the same check.

BUG=666660
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
WebKit: make #if DCHECK_IS_ON consistent in third_party/WebKit/Source/platform/

This CL addresses a few problems with #ifdefs:

1) DCHECK requires the presence of variables used in it even if DCHECK_IS_ON()
evaluates to 0. Therefore, if debug variable is defined only when DCHECK_IS_ON()
is true, its usage must be guarded the same way.

2) If debug method in base class is defined only when DCHECK_IS_ON() is true,
its descendants must be guarded with the same check.

BUG=666660
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[commit-bot: I haz the power, 2016-11-23 12:18:56]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-23 12:21:06]

Description was changed from

==========
WebKit: make #if DCHECK_IS_ON consistent in third_party/WebKit/Source/platform/

This CL addresses a few problems with #ifdefs:

1) DCHECK requires the presence of variables used in it even if DCHECK_IS_ON()
evaluates to 0. Therefore, if debug variable is defined only when DCHECK_IS_ON()
is true, its usage must be guarded the same way.

2) If debug method in base class is defined only when DCHECK_IS_ON() is true,
its descendants must be guarded with the same check.

BUG=666660
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
WebKit: make #if DCHECK_IS_ON consistent in third_party/WebKit/Source/platform/

This CL addresses a few problems with #ifdefs:

1) DCHECK requires the presence of variables used in it even if DCHECK_IS_ON()
evaluates to 0. Therefore, if debug variable is defined only when DCHECK_IS_ON()
is true, its usage must be guarded the same way.

2) If debug method in base class is defined only when DCHECK_IS_ON() is true,
its descendants must be guarded with the same check.

BUG=666660
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/bf362660fce245a3bf521fa2caca26b00e2f055a
Cr-Commit-Position: refs/heads/master@{#434149}
==========

[commit-bot: I haz the power, 2016-11-23 12:21:07]

Patchset 1 (id:??) landed as
https://crrev.com/bf362660fce245a3bf521fa2caca26b00e2f055a
Cr-Commit-Position: refs/heads/master@{#434149}