third_party/WebKit/Source/platform/heap/PersistentNode.h - Issue 2530493002: WebKit: make #if DCHECK_IS_ON consistent in third_party/WebKit/Source/platform/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/heap/PersistentNode.h

Issue 2530493002: WebKit: make #if DCHECK_IS_ON consistent in third_party/WebKit/Source/platform/ (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/heap/PersistentNode.h

diff --git a/third_party/WebKit/Source/platform/heap/PersistentNode.h b/third_party/WebKit/Source/platform/heap/PersistentNode.h

index ae2f68370704f448034d21e66c4c25474a897f5b..b13c76fa877e83111bbed542cb90984140fda83b 100644

--- a/third_party/WebKit/Source/platform/heap/PersistentNode.h

+++ b/third_party/WebKit/Source/platform/heap/PersistentNode.h

@@ -130,7 +130,9 @@ class PLATFORM_EXPORT PersistentRegion final {

}

void freePersistentNode(PersistentNode* persistentNode) {

- ASSERT(m_persistentCount > 0);

+#if DCHECK_IS_ON()

+ DCHECK_GT(m_persistentCount, 0);

Alexander Alekseev 2016/11/23 07:53:07 This variable exists only if DCHECK_IS_ON() evalua

+#endif

persistentNode->setFreeListNext(m_freeListHead);

m_freeListHead = persistentNode;

#if DCHECK_IS_ON()