Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2802)

Unified Diff: build/config/compiler/BUILD.gn

Issue 2530373003: add bug links to two TODOs (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index 4f0db299a507626932794dcaf5becc7f2e10a052..66131c067aface76bafc756da5bcec17aef0498b 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -1068,8 +1068,8 @@ config("chromium_code") {
# The compiler driver can sometimes (rarely) emit warnings before calling
# the actual linker. Make sure these warnings are treated as errors as
# well.
- # TODO(thakis): Enable this in use_custom_libcxx (asan) builds.
- # TODO(thakis): Enable this in chromecast builds.
+ # TODO(thakis): Enable in use_custom_libcxx builds, crbug.com/669072
+ # TODO(thakis): Enable in chromecast builds, crbug.com/669076
if (!use_custom_libcxx && !is_chromecast) {
ldflags = [ "-Werror" ]
}
@@ -1130,8 +1130,8 @@ config("no_chromium_code") {
if (treat_warnings_as_errors && is_clang) {
cflags += [ "-Werror" ]
- # TODO(thakis): Enable this in use_custom_libcxx (asan) builds.
- # TODO(thakis): Enable this in chromecast builds.
+ # TODO(thakis): Enable in use_custom_libcxx builds, crbug.com/669072
+ # TODO(thakis): Enable in chromecast builds, crbug.com/669076
if (!use_custom_libcxx && !is_chromecast) {
ldflags = [ "-Werror" ]
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698