Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Side by Side Diff: build/config/compiler/BUILD.gn

Issue 2530373003: add bug links to two TODOs (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/chromecast_build.gni") 7 import("//build/config/chromecast_build.gni")
8 import("//build/config/compiler/compiler.gni") 8 import("//build/config/compiler/compiler.gni")
9 import("//build/config/nacl/config.gni") 9 import("//build/config/nacl/config.gni")
10 import("//build/config/sanitizers/sanitizers.gni") 10 import("//build/config/sanitizers/sanitizers.gni")
(...skipping 1050 matching lines...) Expand 10 before | Expand all | Expand 10 after
1061 # Assume UTF-8 by default to avoid code page dependencies. 1061 # Assume UTF-8 by default to avoid code page dependencies.
1062 cflags += [ "/utf-8" ] 1062 cflags += [ "/utf-8" ]
1063 } else { 1063 } else {
1064 cflags = [ "-Wall" ] 1064 cflags = [ "-Wall" ]
1065 if (treat_warnings_as_errors) { 1065 if (treat_warnings_as_errors) {
1066 cflags += [ "-Werror" ] 1066 cflags += [ "-Werror" ]
1067 1067
1068 # The compiler driver can sometimes (rarely) emit warnings before calling 1068 # The compiler driver can sometimes (rarely) emit warnings before calling
1069 # the actual linker. Make sure these warnings are treated as errors as 1069 # the actual linker. Make sure these warnings are treated as errors as
1070 # well. 1070 # well.
1071 # TODO(thakis): Enable this in use_custom_libcxx (asan) builds. 1071 # TODO(thakis): Enable in use_custom_libcxx builds, crbug.com/669072
1072 # TODO(thakis): Enable this in chromecast builds. 1072 # TODO(thakis): Enable in chromecast builds, crbug.com/669076
1073 if (!use_custom_libcxx && !is_chromecast) { 1073 if (!use_custom_libcxx && !is_chromecast) {
1074 ldflags = [ "-Werror" ] 1074 ldflags = [ "-Werror" ]
1075 } 1075 }
1076 } 1076 }
1077 if (is_clang) { 1077 if (is_clang) {
1078 # Enable -Wextra for chromium_code when we control the compiler. 1078 # Enable -Wextra for chromium_code when we control the compiler.
1079 cflags += [ "-Wextra" ] 1079 cflags += [ "-Wextra" ]
1080 } 1080 }
1081 1081
1082 # In Chromium code, we define __STDC_foo_MACROS in order to get the 1082 # In Chromium code, we define __STDC_foo_MACROS in order to get the
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
1123 defines += [ 1123 defines += [
1124 "_CRT_NONSTDC_NO_WARNINGS", 1124 "_CRT_NONSTDC_NO_WARNINGS",
1125 "_CRT_NONSTDC_NO_DEPRECATE", 1125 "_CRT_NONSTDC_NO_DEPRECATE",
1126 ] 1126 ]
1127 } else { 1127 } else {
1128 # GCC may emit unsuppressible warnings so don't add -Werror for no chromium 1128 # GCC may emit unsuppressible warnings so don't add -Werror for no chromium
1129 # code. crbug.com/589724 1129 # code. crbug.com/589724
1130 if (treat_warnings_as_errors && is_clang) { 1130 if (treat_warnings_as_errors && is_clang) {
1131 cflags += [ "-Werror" ] 1131 cflags += [ "-Werror" ]
1132 1132
1133 # TODO(thakis): Enable this in use_custom_libcxx (asan) builds. 1133 # TODO(thakis): Enable in use_custom_libcxx builds, crbug.com/669072
1134 # TODO(thakis): Enable this in chromecast builds. 1134 # TODO(thakis): Enable in chromecast builds, crbug.com/669076
1135 if (!use_custom_libcxx && !is_chromecast) { 1135 if (!use_custom_libcxx && !is_chromecast) {
1136 ldflags = [ "-Werror" ] 1136 ldflags = [ "-Werror" ]
1137 } 1137 }
1138 } 1138 }
1139 if (is_clang && !is_nacl) { 1139 if (is_clang && !is_nacl) {
1140 # TODO(thakis): Remove !is_nacl once 1140 # TODO(thakis): Remove !is_nacl once
1141 # https://codereview.webrtc.org/1552863002/ made its way into chromium. 1141 # https://codereview.webrtc.org/1552863002/ made its way into chromium.
1142 cflags += [ "-Wall" ] 1142 cflags += [ "-Wall" ]
1143 } 1143 }
1144 } 1144 }
(...skipping 489 matching lines...) Expand 10 before | Expand all | Expand 10 after
1634 1634
1635 if (is_ios || is_mac) { 1635 if (is_ios || is_mac) {
1636 # On Mac and iOS, this enables support for ARC (automatic ref-counting). 1636 # On Mac and iOS, this enables support for ARC (automatic ref-counting).
1637 # See http://clang.llvm.org/docs/AutomaticReferenceCounting.html. 1637 # See http://clang.llvm.org/docs/AutomaticReferenceCounting.html.
1638 config("enable_arc") { 1638 config("enable_arc") {
1639 common_flags = [ "-fobjc-arc" ] 1639 common_flags = [ "-fobjc-arc" ]
1640 cflags_objc = common_flags 1640 cflags_objc = common_flags
1641 cflags_objcc = common_flags 1641 cflags_objcc = common_flags
1642 } 1642 }
1643 } 1643 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698