Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2530373003:
add bug links to two TODOs (Closed)
|
Created:
4 years ago by Nico Modified:
4 years ago Reviewers:
Reid Kleckner CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionadd bug links to two TODOs
BUG=
Committed: https://crrev.com/e2685f7d23132cfea70a183993ec7fbad0922105
Cr-Commit-Position: refs/heads/master@{#434695}
Patch Set 1 #
Messages
Total messages: 19 (10 generated)
thakis@chromium.org changed reviewers: + rnk@chromium.org
thakis@chromium.org changed reviewers: + rnk@chromium.org
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
On 2016/11/28 17:28:54, commit-bot: I haz the power wrote: > No L-G-T-M from a valid reviewer yet. > CQ run can only be started by full committers or once the patch has > received an L-G-T-M from a full committer. > Even if an L-G-T-M may have been provided, it was from a non-committer, > _not_ a full super star committer. > See http://www.chromium.org/getting-involved/become-a-committer > Note that this has nothing to do with OWNERS files. sorry, meant to hit "dry run"
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Comment update lgtm either way :)
The CQ bit was unchecked by thakis@chromium.org
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1480355122377540, "parent_rev":
"a73b0bd4e5bfe127f0ad68a7cd87c59a36a2ae32", "commit_rev":
"dfa3182281731bc3a4afcb51abcedb421bd19e3a"}
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== add bug links to two TODOs BUG= ========== to ========== add bug links to two TODOs BUG= Committed: https://crrev.com/e2685f7d23132cfea70a183993ec7fbad0922105 Cr-Commit-Position: refs/heads/master@{#434695} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/e2685f7d23132cfea70a183993ec7fbad0922105 Cr-Commit-Position: refs/heads/master@{#434695} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
