Status page for the new analysis driver.

Status page for the new analysis driver.

Probably more info should be added with time.
But this lets us see drivers and files.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/a573765c18d08de7715f7cb0b010c2a0de89dc58

[scheglov, 2016-11-27 19:54:27]

Description was changed from

==========
Status page for the new analysis driver.

R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

to

==========
Status page for the new analysis driver.

Probably more info should be added with time.
But this lets us see drivers and files.

R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

[Paul Berry, 2016-11-27 23:16:17]

https://codereview.chromium.org/2530273004/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/server/http_server.dart (right):

https://codereview.chromium.org/2530273004/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/server/http_server.dart:35: Object getHandler;
How about if we make a common base class that both kinds of GetHandlers
implement?

https://codereview.chromium.org/2530273004/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/server/http_server.dart:88: if (getHandler is
GetHandler2) {
Then we wouldn't need this if-test

https://codereview.chromium.org/2530273004/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/server/http_server.dart:92: }
If we do keep the if-test, I'd prefer to have a final "else" clause that throws
an exception, so that if there's an unexpected object type in getHandler, the
request won't just get silently dropped on the floor.

https://codereview.chromium.org/2530273004/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/status/get_handler2.dart (right):

https://codereview.chromium.org/2530273004/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/status/get_handler2.dart:385: //    List<String>
priorityNames = <String>[];
Can you add a TODO comment indicating what you intend to do with this
commented-out code?

https://codereview.chromium.org/2530273004/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/status/get_handler2.dart:392: //   
_overlayContents.clear();
Same here

https://codereview.chromium.org/2530273004/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/status/get_handler2.dart:517: //        _writeFiles(
And here

https://codereview.chromium.org/2530273004/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/status/get_handler2.dart:525: //       
buffer.write('<h3>Exceptions</h3>');
And here

[scheglov, 2016-11-28 16:28:43]

PTAL

https://codereview.chromium.org/2530273004/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/server/http_server.dart (right):

https://codereview.chromium.org/2530273004/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/server/http_server.dart:35: Object getHandler;
On 2016/11/27 23:16:17, Paul Berry wrote:
> How about if we make a common base class that both kinds of GetHandlers
> implement?

Done.

https://codereview.chromium.org/2530273004/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/server/http_server.dart:88: if (getHandler is
GetHandler2) {
On 2016/11/27 23:16:17, Paul Berry wrote:
> Then we wouldn't need this if-test

Done.

https://codereview.chromium.org/2530273004/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/status/get_handler2.dart (right):

https://codereview.chromium.org/2530273004/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/status/get_handler2.dart:385: //    List<String>
priorityNames = <String>[];
On 2016/11/27 23:16:17, Paul Berry wrote:
> Can you add a TODO comment indicating what you intend to do with this
> commented-out code?

Done.

https://codereview.chromium.org/2530273004/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/status/get_handler2.dart:392: //   
_overlayContents.clear();
On 2016/11/27 23:16:17, Paul Berry wrote:
> Same here

Done.

https://codereview.chromium.org/2530273004/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/status/get_handler2.dart:517: //        _writeFiles(
On 2016/11/27 23:16:17, Paul Berry wrote:
> And here

Done.

https://codereview.chromium.org/2530273004/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/status/get_handler2.dart:525: //       
buffer.write('<h3>Exceptions</h3>');
On 2016/11/27 23:16:17, Paul Berry wrote:
> And here

Done.

[Brian Wilkerson, 2016-11-28 17:09:21]

lgtm

https://codereview.chromium.org/2530273004/diff/20001/pkg/analysis_server/lib...
File pkg/analysis_server/lib/src/status/get_handler2.dart (right):

https://codereview.chromium.org/2530273004/diff/20001/pkg/analysis_server/lib...
pkg/analysis_server/lib/src/status/get_handler2.dart:1: // Copyright (c) 2014,
the Dart project authors.  Please see the AUTHORS file
"2014" --> "2016"

[scheglov, 2016-11-28 17:15:36]

Description was changed from

==========
Status page for the new analysis driver.

Probably more info should be added with time.
But this lets us see drivers and files.

R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

to

==========
Status page for the new analysis driver.

Probably more info should be added with time.
But this lets us see drivers and files.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/a573765c18d08de7715f7cb0b010c2a0de89dc58
==========

[scheglov, 2016-11-28 17:15:37]

Committed patchset #2 (id:20001) manually as
a573765c18d08de7715f7cb0b010c2a0de89dc58 (presubmit successful).

[Paul Berry, 2016-11-28 18:53:57]

lgtm